Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/filterClasses.js

Issue 29853561: Issue 6854 - Remove deprecated FilterNotifier methods (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Created Aug. 11, 2018, 2:43 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/filterNotifier.js » ('j') | test/filterNotifier.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/filterClasses.js
===================================================================
--- a/lib/filterClasses.js
+++ b/lib/filterClasses.js
@@ -328,17 +328,17 @@
return this._disabled;
},
set disabled(value)
{
if (value != this._disabled)
{
let oldValue = this._disabled;
this._disabled = value;
- FilterNotifier.triggerListeners("filter.disabled", this, value, oldValue);
+ FilterNotifier.emit("filter.disabled", this, value, oldValue);
}
return this._disabled;
},
/**
* Number of hits on the filter since the last reset
* @type {number}
*/
@@ -347,17 +347,17 @@
return this._hitCount;
},
set hitCount(value)
{
if (value != this._hitCount)
{
let oldValue = this._hitCount;
this._hitCount = value;
- FilterNotifier.triggerListeners("filter.hitCount", this, value, oldValue);
+ FilterNotifier.emit("filter.hitCount", this, value, oldValue);
}
return this._hitCount;
},
/**
* Last time the filter had a hit (in milliseconds since the beginning of the
* epoch)
* @type {number}
@@ -367,17 +367,17 @@
return this._lastHit;
},
set lastHit(value)
{
if (value != this._lastHit)
{
let oldValue = this._lastHit;
this._lastHit = value;
- FilterNotifier.triggerListeners("filter.lastHit", this, value, oldValue);
+ FilterNotifier.emit("filter.lastHit", this, value, oldValue);
}
return this._lastHit;
},
/**
* String that the domains property should be generated from
* @type {?string}
*/
« no previous file with comments | « no previous file | lib/filterNotifier.js » ('j') | test/filterNotifier.js » ('J')

Powered by Google App Engine
This is Rietveld