Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: lib/filterNotifier.js

Issue 29853561: Issue 6854 - Remove deprecated FilterNotifier methods (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Created Aug. 11, 2018, 2:43 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/filterNotifier.js
===================================================================
--- a/lib/filterNotifier.js
+++ b/lib/filterNotifier.js
@@ -18,69 +18,14 @@
"use strict";
/**
* @fileOverview This component manages listeners and calls them to distributes
* messages about filter changes.
*/
const {EventEmitter} = require("./events");
-const {desc} = require("./coreUtils");
-
-const CATCH_ALL = "__all";
-
-/**
- * @callback FilterNotifierCatchAllListener
- * @param {string} action
- * @param {Subscription|Filter} item
- * @param {...*} additionalInfo
- */
/**
* This class allows registering and triggering listeners for filter events.
* @class
*/
-exports.FilterNotifier = Object.create(new EventEmitter(), desc({
- /**
- * Adds a listener
- *
- * @deprecated use FilterNotifier.on(action, callback)
- * @param {FilterNotifierCatchAllListener} listener
- */
- addListener(listener)
- {
- let listeners = this._listeners.get(CATCH_ALL);
- if (!listeners || listeners.indexOf(listener) == -1)
- this.on(CATCH_ALL, listener);
- },
-
- /**
- * Removes a listener that was previosly added via addListener
- *
- * @deprecated use FilterNotifier.off(action, callback)
- * @param {FilterNotifierCatchAllListener} listener
- */
- removeListener(listener)
- {
- this.off(CATCH_ALL, listener);
- },
-
- /**
- * Notifies listeners about an event
- * @param {string} action event code ("load", "save", "elemhideupdate",
- * "subscription.added", "subscription.removed",
- * "subscription.disabled", "subscription.title",
- * "subscription.lastDownload", "subscription.downloadStatus",
- * "subscription.homepage", "subscription.updated",
- * "filter.added", "filter.removed", "filter.moved",
- * "filter.disabled", "filter.hitCount", "filter.lastHit")
- * @param {Subscription|Filter} item item that the change applies to
- * @param {*} param1
- * @param {*} param2
- * @param {*} param3
- * @deprecated use FilterNotifier.emit(action)
- */
- triggerListeners(action, item, param1, param2, param3)
- {
- this.emit(action, item, param1, param2, param3);
- this.emit(CATCH_ALL, action, item, param1, param2, param3);
- }
-}));
+exports.FilterNotifier = Object.create(new EventEmitter());
« no previous file with comments | « lib/filterClasses.js ('k') | lib/filterStorage.js » ('j') | test/filterNotifier.js » ('J')

Powered by Google App Engine
This is Rietveld