Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29853570: Issue 6908 - Pass updated subscription's old filters as an event argument (Closed)

Created:
Aug. 11, 2018, 2:52 p.m. by Manish Jethani
Modified:
Sept. 4, 2018, 5:25 p.m.
Reviewers:
hub
CC:
kzar
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M lib/filterListener.js View 1 1 chunk +2 lines, -2 lines 0 comments Download
M lib/filterStorage.js View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6
Manish Jethani
Aug. 11, 2018, 2:52 p.m. (2018-08-11 14:52:44 UTC) #1
Manish Jethani
Patch Set 1
Aug. 11, 2018, 2:53 p.m. (2018-08-11 14:53:51 UTC) #2
hub
this needs to be rebased.
Aug. 29, 2018, 4:20 p.m. (2018-08-29 16:20:22 UTC) #3
Manish Jethani
Patch Set 2: Rebase
Aug. 29, 2018, 6:07 p.m. (2018-08-29 18:07:14 UTC) #4
Manish Jethani
Since this is an API change that requires changes in other modules, I have filed ...
Aug. 29, 2018, 6:16 p.m. (2018-08-29 18:16:07 UTC) #5
hub
Sept. 4, 2018, 5:04 p.m. (2018-09-04 17:04:04 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld