Unified Diff: lib/synchronizer.js
Issue 29853574:
Issue 6855 - Release all references to Subscription object once removed (Closed)
Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set:
Created Aug. 11, 2018, 3:21 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« lib/filterStorage.js ('K')
|
« lib/subscriptionClasses.js ('k')
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: lib/synchronizer.js |
| =================================================================== |
| --- a/lib/synchronizer.js |
| +++ b/lib/synchronizer.js |
| @@ -199,17 +199,17 @@ |
| subscription.title = oldSubscription.title; |
| subscription.disabled = oldSubscription.disabled; |
| subscription.lastCheck = oldSubscription.lastCheck; |
| let listed = FilterStorage.knownSubscriptions.has(oldSubscription.url); |
| if (listed) |
| FilterStorage.removeSubscription(oldSubscription); |
| - Subscription.knownSubscriptions.delete(oldSubscription.url); |
| + oldSubscription.free(); |
| if (listed) |
| FilterStorage.addSubscription(subscription); |
| } |
| // The download actually succeeded |
| subscription.lastSuccess = subscription.lastDownload = Math.round( |
| Date.now() / MILLIS_IN_SECOND |
« lib/filterStorage.js ('K')
|
« lib/subscriptionClasses.js ('k')
|
no next file »
|
no next file with comments »
