lib/synchronizer.js - Issue 29853574: Issue 6855 - Release all references to Subscription object once removed

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: lib/synchronizer.js

Issue 29853574: Issue 6855 - Release all references to Subscription object once removed (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/

Patch Set: Created Aug. 11, 2018, 3:21 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/synchronizer.js

===================================================================

--- a/lib/synchronizer.js

+++ b/lib/synchronizer.js

@@ -199,17 +199,17 @@

subscription.title = oldSubscription.title;

subscription.disabled = oldSubscription.disabled;

subscription.lastCheck = oldSubscription.lastCheck;

let listed = FilterStorage.knownSubscriptions.has(oldSubscription.url);

if (listed)

FilterStorage.removeSubscription(oldSubscription);

- Subscription.knownSubscriptions.delete(oldSubscription.url);

+ oldSubscription.free();

if (listed)

FilterStorage.addSubscription(subscription);

}

// The download actually succeeded

subscription.lastSuccess = subscription.lastDownload = Math.round(

Date.now() / MILLIS_IN_SECOND

« lib/filterStorage.js ('K') | « lib/subscriptionClasses.js ('k') | no next file » | no next file with comments »