Unified Diff: lib/filterStorage.js
Issue 29853574:
Issue 6855 - Release all references to Subscription object once removed (Closed)
Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Improve tests
Created Aug. 16, 2018, 5:33 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
test/filterStorage.js » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: lib/filterStorage.js |
| =================================================================== |
| --- a/lib/filterStorage.js |
| +++ b/lib/filterStorage.js |
| @@ -143,16 +143,21 @@ |
| for (let i = 0; i < FilterStorage.subscriptions.length; i++) |
| { |
| if (FilterStorage.subscriptions[i].url == subscription.url) |
| { |
| removeSubscriptionFilters(subscription); |
| FilterStorage.subscriptions.splice(i--, 1); |
| FilterStorage.knownSubscriptions.delete(subscription.url); |
| + |
| + // This should be the last remaining reference to the Subscription |
| + // object. |
| + Subscription.knownSubscriptions.delete(subscription.url); |
| + |
| FilterNotifier.triggerListeners("subscription.removed", subscription); |
| return; |
| } |
| } |
| }, |
| /** |
| * Moves a subscription in the list to a new position. |
« no previous file with comments
|
« no previous file
|
test/filterStorage.js » ('j')
|
no next file with comments »
