Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(657)

Issue 29854572: Issue 6857 - Do not serialize empty special subscriptions

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 1 week ago by Manish Jethani
Modified:
3 weeks, 2 days ago
Reviewers:
hub
CC:
kzar, sergei
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Tentative fix for the issue. We can keep the objects in memory, but at least we shouldn't serialize them to disk.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -3 lines) Patch
M lib/filterStorage.js View 1 chunk +2 lines, -1 line 0 comments Download
M test/filterStorage_readwrite.js View 4 chunks +22 lines, -2 lines 0 comments Download

Messages

Total messages: 3
Manish Jethani
1 month, 1 week ago (2018-08-12 10:28:39 UTC) #1
Manish Jethani
Patch Set 1
1 month, 1 week ago (2018-08-12 10:31:23 UTC) #2
hub
3 weeks, 2 days ago (2018-08-27 13:07:33 UTC) #3
LGTM

but I think Dave should have a good look at it.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5