Issue 29854572: Issue 6857 - Do not serialize empty special subscriptions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29854572: Issue 6857 - Do not serialize empty special subscriptions (Closed)

Created:
Aug. 12, 2018, 10:28 a.m. by Manish Jethani

Modified:
Oct. 3, 2018, 4:01 p.m.

Reviewers:
kzar, hub

CC:
sergei, Jon Sonesen

Base URL:
https://hg.adblockplus.org/adblockpluscore/

Visibility:
Public.

Description

Tentative fix for the issue. We can keep the objects in memory, but at least we shouldn't serialize them to disk.

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Use temporary Set object in unit test #

Created: Oct. 3, 2018, 3:56 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -3 lines)			Patch
	M	lib/filterStorage.js	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
	M	test/filterStorage_readwrite.js	View	1 2	4 chunks	+22 lines, -2 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Manish Jethani

Patch Set 2: Rebase Dave, would you like to take a look at this?

Oct. 3, 2018, 1:29 p.m. (2018-10-03 13:29:46 UTC) #4

kzar

On 2018/10/03 13:29:46, Manish Jethani wrote: > Dave, would you like to take a look ...

Oct. 3, 2018, 1:44 p.m. (2018-10-03 13:44:28 UTC) #5

Manish Jethani

Oct. 3, 2018, 3:58 p.m. (2018-10-03 15:58:38 UTC) #6

Patch Set 3: Use temporary Set object in unit test

On 2018/10/03 13:44:28, kzar wrote:
> On 2018/10/03 13:29:46, Manish Jethani wrote:
> 
> > Dave, would you like to take a look at this?
> 
> No, I don't want to block you. If you're happy then go ahead.

Alright, since Hubert is on holiday and the change between the first patch and
the third one is trivial and only in a test file, I'll go ahead and land this.

Thanks!

Expand All Messages | Collapse All Messages