Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(710)

Issue 29856560: Issue 6861 - Do not escape in-filter brackets during serialization (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 9 months ago by Manish Jethani
Modified:
1 year, 9 months ago
Reviewers:
sergei
CC:
hub, kzar
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Issue 6861 - Do not escape in-filter brackets during serialization

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3265 lines, -3265 lines) Patch
M lib/subscriptionClasses.js View 1 chunk +1 line, -1 line 0 comments Download
M test/data/patterns.ini View 66 chunks +3264 lines, -3264 lines 0 comments Download

Messages

Total messages: 3
Manish Jethani
1 year, 9 months ago (2018-08-15 12:00:52 UTC) #1
Manish Jethani
Patch Set 1 In `test/data/patterns.ini` I basically did `s/\(\S\)\\\[/\1[/g` throughout the file. Please comment on ...
1 year, 9 months ago (2018-08-15 12:04:14 UTC) #2
Manish Jethani
1 year, 9 months ago (2018-08-22 06:34:25 UTC) #3
Message was sent while issue was closed.
Withdrawing this patch now since we agreed to bump the version number, which
then also gives us the opportunity to make more performance-friendly changes to
the patterns.ini format in a backwards compatible way.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5