Issue 6867 - Fix pytest 3.7.1 mock regression

Issue 6867 - Fix pytest 3.7.1 mock regression

[rhowell, 2018-08-16 21:07:56]

Looks like this fixes the issue. Just a super minor nit and one question.
Thanks!  :)

https://codereview.adblockplus.org/29857615/diff/29857616/tox.ini
File tox.ini (right):

https://codereview.adblockplus.org/29857615/diff/29857616/tox.ini#newcode2
tox.ini:2: envlist = py27
Unrelated, but why is this only testing Python 2? Just curious.

https://codereview.adblockplus.org/29857615/diff/29857616/tox.ini#newcode20
tox.ini:20: deps = flask
Maybe leave this on two different lines? Looks like that's standard for most of
the other tox.ini files.

[Jon Sonesen, 2018-08-16 21:10:41]

Thanks for the feedback!

https://codereview.adblockplus.org/29857615/diff/29857616/tox.ini
File tox.ini (right):

https://codereview.adblockplus.org/29857615/diff/29857616/tox.ini#newcode20
tox.ini:20: deps = flask
On 2018/08/16 21:07:55, rhowell wrote:
> Maybe leave this on two different lines? Looks like that's standard for most
of
> the other tox.ini files.

Acknowledged.

[Vasily Kuznetsov, 2018-08-17 11:56:24]

LGTM

https://codereview.adblockplus.org/29857615/diff/29857621/tox.ini
File tox.ini (right):

https://codereview.adblockplus.org/29857615/diff/29857621/tox.ini#newcode27
tox.ini:27: mock
You don't really need to replace this dependency. OTOH we don't really use
pytest-mock API (and didn't before) so we might as well get rid of it, I guess.

[Jon Sonesen, 2018-08-17 17:27:51]

https://codereview.adblockplus.org/29857615/diff/29857621/tox.ini
File tox.ini (right):

https://codereview.adblockplus.org/29857615/diff/29857621/tox.ini#newcode27
tox.ini:27: mock
On 2018/08/17 11:56:24, Vasily Kuznetsov wrote:
> You don't really need to replace this dependency. OTOH we don't really use
> pytest-mock API (and didn't before) so we might as well get rid of it, I
guess.

My bad, I just pushed this :/ in the docs they mention using the pip package for
more up to date versions of the mock library.

[Jon Sonesen, 2018-08-17 17:27:52]

https://codereview.adblockplus.org/29857615/diff/29857621/tox.ini
File tox.ini (right):

https://codereview.adblockplus.org/29857615/diff/29857621/tox.ini#newcode27
tox.ini:27: mock
On 2018/08/17 11:56:24, Vasily Kuznetsov wrote:
> You don't really need to replace this dependency. OTOH we don't really use
> pytest-mock API (and didn't before) so we might as well get rid of it, I
guess.

My bad, I just pushed this :/ in the docs they mention using the pip package for
more up to date versions of the mock library.