Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(122)

Issue 29857615: Issue 6867 - Fix pytest 3.7.1 mock regression (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 6 months ago by Jon Sonesen
Modified:
1 year, 6 months ago
Base URL:
https://hg.adblockplus.org/cms
Visibility:
Public.

Description

Issue 6867 - Fix pytest 3.7.1 mock regression

Patch Set 1 #

Total comments: 3

Patch Set 2 : Address PS1 Comments #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M tests/test_page_outputs.py View 1 chunk +2 lines, -3 lines 0 comments Download
M tox.ini View 1 1 chunk +1 line, -2 lines 2 comments Download

Messages

Total messages: 6
Jon Sonesen
1 year, 6 months ago (2018-08-16 19:38:53 UTC) #1
rhowell
Looks like this fixes the issue. Just a super minor nit and one question. Thanks! ...
1 year, 6 months ago (2018-08-16 21:07:56 UTC) #2
Jon Sonesen
Thanks for the feedback! https://codereview.adblockplus.org/29857615/diff/29857616/tox.ini File tox.ini (right): https://codereview.adblockplus.org/29857615/diff/29857616/tox.ini#newcode20 tox.ini:20: deps = flask On 2018/08/16 ...
1 year, 6 months ago (2018-08-16 21:10:41 UTC) #3
Vasily Kuznetsov
LGTM https://codereview.adblockplus.org/29857615/diff/29857621/tox.ini File tox.ini (right): https://codereview.adblockplus.org/29857615/diff/29857621/tox.ini#newcode27 tox.ini:27: mock You don't really need to replace this ...
1 year, 6 months ago (2018-08-17 11:56:24 UTC) #4
Jon Sonesen
https://codereview.adblockplus.org/29857615/diff/29857621/tox.ini File tox.ini (right): https://codereview.adblockplus.org/29857615/diff/29857621/tox.ini#newcode27 tox.ini:27: mock On 2018/08/17 11:56:24, Vasily Kuznetsov wrote: > You ...
1 year, 6 months ago (2018-08-17 17:27:51 UTC) #5
Jon Sonesen
1 year, 6 months ago (2018-08-17 17:27:52 UTC) #6
https://codereview.adblockplus.org/29857615/diff/29857621/tox.ini
File tox.ini (right):

https://codereview.adblockplus.org/29857615/diff/29857621/tox.ini#newcode27
tox.ini:27: mock
On 2018/08/17 11:56:24, Vasily Kuznetsov wrote:
> You don't really need to replace this dependency. OTOH we don't really use
> pytest-mock API (and didn't before) so we might as well get rid of it, I
guess.

My bad, I just pushed this :/ in the docs they mention using the pip package for
more up to date versions of the mock library.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5