Issue 6391 - WebDriver: Fix runtime problen with Gecko and Firefox

test/runners/chromium_process.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 17 matching lines @@
 // Chromium 63.0.3239.x is 508578
 // Chromium 65.0.3325.0 is 530368
 // We currently want Chromiun 63, as we still support it and that's the
 // loweset version that supports WebDriver.
 const CHROMIUM_REVISION = 508578;
 
 function runScript(chromiumPath, script, scriptName, scriptArgs)
 {
   const options = new chrome.Options()
         .headless()
+        // disabling sandboxing. It is needed on some systems.

[Sebastian Noack, 2018/08/22 17:02:04]

Nit: Proper capitalization and punctuation please:

  Disabling sandboxing, as needed on some systems.

You also might want to specify "some systems" a little more.

[hub, 2018/08/22 17:36:55]

Done.

+        .addArguments("--no-sandbox")
         .setChromeBinaryPath(chromiumPath);
 
   const driver = new Builder()
         .forBrowser("chrome")
         .setChromeOptions(options)
         .build();
 
   return executeScript(driver, "Chromium (WebDriver)",
                        script, scriptName, scriptArgs);
 }
 
 module.exports = function(script, scriptName, ...scriptArgs)
 {
   return ensureChromium(CHROMIUM_REVISION).then(chromiumPath =>
   {
     return runScript(chromiumPath, script, scriptName, scriptArgs)
       .then(result => result)
       .catch(error =>
       {
         console.log("chromium_process: error caught");
         throw error;
       });
   });
 };