Side by Side Diff: README.md
Issue 29860555:
Issue 6717 - Part 2: run qunit in headless firefox (Closed)
Base URL: https://hg.adblockplus.org/adblockpluschrome/file/3270e924ba9f
Patch Set:
Created Aug. 24, 2018, 9:55 a.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
dependencies » ('j')
|
test/firefox.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| OLD | NEW |
|---|---|
| 1 Adblock Plus for Chrome, Opera, Microsoft Edge and Firefox | 1 Adblock Plus for Chrome, Opera, Microsoft Edge and Firefox |
| 2 ========================================================== | 2 ========================================================== |
| 3 | 3 |
| 4 This repository contains the platform-specific Adblock Plus source code for | 4 This repository contains the platform-specific Adblock Plus source code for |
| 5 Chrome, Opera, Microsoft Edge and Firefox. It can be used to build | 5 Chrome, Opera, Microsoft Edge and Firefox. It can be used to build |
| 6 Adblock Plus for these platforms, generic Adblock Plus code will be extracted | 6 Adblock Plus for these platforms, generic Adblock Plus code will be extracted |
| 7 from other repositories automatically (see _dependencies_ file). | 7 from other repositories automatically (see _dependencies_ file). |
| 8 | 8 |
| 9 Note that the Firefox extension built from this repository is the new | 9 Note that the Firefox extension built from this repository is the new |
| 10 [WebExtension](https://developer.mozilla.org/en-US/Add-ons/WebExtensions). | 10 [WebExtension](https://developer.mozilla.org/en-US/Add-ons/WebExtensions). |
| (...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 79 Running the unit tests | 79 Running the unit tests |
| 80 ---------------------- | 80 ---------------------- |
| 81 | 81 |
| 82 To verify your changes you can use the unit test suite located in the _qunit_ | 82 To verify your changes you can use the unit test suite located in the _qunit_ |
| 83 directory of the repository. In order to run the unit tests go to the | 83 directory of the repository. In order to run the unit tests go to the |
| 84 extension's Options page, open the JavaScript Console and type in: | 84 extension's Options page, open the JavaScript Console and type in: |
| 85 | 85 |
| 86 location.href = "qunit/index.html"; | 86 location.href = "qunit/index.html"; |
| 87 | 87 |
| 88 The unit tests will run automatically once the page loads. | 88 The unit tests will run automatically once the page loads. |
| 89 You can also run these tests with a headless Firefox process. Install the | |
| 90 dependencies first: | |
| 91 | |
| 92 npm install | |
| 93 | |
| 94 Start the testing process: | |
| 95 | |
| 96 npm test -- gecko | |
|
Sebastian Noack
2018/08/24 12:29:10
This needs to be changed too now.
tlucas
2018/08/24 12:46:21
Done.
| |
| 89 | 97 |
| 90 Linting | 98 Linting |
| 91 ------- | 99 ------- |
| 92 | 100 |
| 93 You can lint the code using [ESLint](http://eslint.org). | 101 You can lint the code using [ESLint](http://eslint.org). |
| 94 | 102 |
| 95 You will need to setup first. This will install our configuration | 103 You will need to setup first. This will install our configuration |
| 96 [eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/tip/eslint-conf ig-eyeo) | 104 [eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/tip/eslint-conf ig-eyeo) |
| 97 and everything needed after you run: | 105 and everything needed after you run: |
| 98 | 106 |
| 99 npm install | 107 npm install |
| 100 | 108 |
| 101 Then you can run to lint the code: | 109 Then you can run to lint the code: |
| 102 | 110 |
| 103 npm run lint | 111 npm run lint |
| 104 | |
| OLD | NEW |
« no previous file with comments
|
« no previous file
|
dependencies » ('j')
|
test/firefox.js » ('J')
