README.md - Issue 29860555: Issue 6717 - Part 2: run qunit in headless firefox

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: README.md

Issue 29860555: Issue 6717 - Part 2: run qunit in headless firefox (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/file/3270e924ba9f

Left Patch Set: Removing test_runner.js Created Aug. 22, 2018, 7:03 a.m.

Right Patch Set: No func change, reindent Created Aug. 24, 2018, 6:56 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 Adblock Plus for Chrome, Opera, Microsoft Edge and Firefox	1 Adblock Plus for Chrome, Opera, Microsoft Edge and Firefox

2 ==========================================================	2 ==========================================================

3	3

4 This repository contains the platform-specific Adblock Plus source code for	4 This repository contains the platform-specific Adblock Plus source code for

5 Chrome, Opera, Microsoft Edge and Firefox. It can be used to build	5 Chrome, Opera, Microsoft Edge and Firefox. It can be used to build

6 Adblock Plus for these platforms, generic Adblock Plus code will be extracted	6 Adblock Plus for these platforms, generic Adblock Plus code will be extracted

7 from other repositories automatically (see _dependencies_ file).	7 from other repositories automatically (see _dependencies_ file).

8	8

9 Note that the Firefox extension built from this repository is the new	9 Note that the Firefox extension built from this repository is the new

10 [WebExtension](https://developer.mozilla.org/en-US/Add-ons/WebExtensions).	10 [WebExtension](https://developer.mozilla.org/en-US/Add-ons/WebExtensions).

(...skipping 68 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
79 Running the unit tests	79 Running the unit tests

80 ----------------------	80 ----------------------

81	81

82 To verify your changes you can use the unit test suite located in the _qunit_	82 To verify your changes you can use the unit test suite located in the _qunit_

83 directory of the repository. In order to run the unit tests go to the	83 directory of the repository. In order to run the unit tests go to the

84 extension's Options page, open the JavaScript Console and type in:	84 extension's Options page, open the JavaScript Console and type in:

85	85

86 location.href = "qunit/index.html";	86 location.href = "qunit/index.html";

87	87

88 The unit tests will run automatically once the page loads.	88 The unit tests will run automatically once the page loads.

89 You can also run theses tests with a headless Firefox process. Install the	89 You can also run these tests with a headless Firefox process. Install the

90 dependencies first:	90 dependencies first:

91	91

92 npm install	92 npm install

93	93

94 Start the testing process:	94 Start the testing process:

95	95

96 npm test -- gecko	96 npm test

97	97

98 Linting	98 Linting

99 -------	99 -------

100	100

101 You can lint the code using [ESLint](http://eslint.org).	101 You can lint the code using [ESLint](http://eslint.org).

102	102

103 You will need to setup first. This will install our configuration	103 You will need to setup first. This will install our configuration

104 [eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/tip/eslint-conf ig-eyeo)	104 [eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/tip/eslint-conf ig-eyeo)

105 and everything needed after you run:	105 and everything needed after you run:

106	106

107 npm install	107 npm install

108	108

109 Then you can run to lint the code:	109 Then you can run to lint the code:

110	110

111 npm run lint	111 npm run lint

LEFT	RIGHT