Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: package.json

Issue 29860555: Issue 6717 - Part 2: run qunit in headless firefox (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/file/3270e924ba9f
Left Patch Set: Fix type in README.md Created Aug. 22, 2018, 7:04 a.m.
Right Patch Set: No func change, reindent Created Aug. 24, 2018, 6:56 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « dependencies ('k') | test/firefox.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 { 1 {
2 "name": "adblockpluschrome", 2 "name": "adblockpluschrome",
3 "repository": "https://hg.adblockplus.org/adblockpluschrome", 3 "repository": "https://hg.adblockplus.org/adblockpluschrome",
4 "license": "GPL-3.0", 4 "license": "GPL-3.0",
5 "dependencies": {}, 5 "dependencies": {},
6 "devDependencies": { 6 "devDependencies": {
7 "dmg": "0.1.0", 7 "//": [
8 "'dmg', 'extract-zip' and 'ncp' are needed by the module",
9 "adblockpluscore/test/download_firefox.js."
10 ],
11 "dmg": "^0.1.0",
8 "eslint": "^5.1.0", 12 "eslint": "^5.1.0",
9 "eslint-config-eyeo": "^2.1.0", 13 "eslint-config-eyeo": "^2.1.0",
10 "extract-zip": "1.6.5", 14 "extract-zip": "^1.6.5",
11 "geckodriver": "^1.9.0", 15 "geckodriver": "^1.9.0",
12 "ncp": "2.0.0", 16 "ncp": "^2.0.0",
13 "nodeunit": "0.9.1", 17 "nodeunit": "^0.9.1",
Sebastian Noack 2018/08/22 18:16:38 Any reason you pin exact versions for dmg, extract
hub 2018/08/22 19:21:08 For "dmg" it is the exact same as in adblockplusco
Sebastian Noack 2018/08/22 20:06:43 Acknowledged, but what is about the other dependen
tlucas 2018/08/22 20:24:00 No real reason, besides following Hubert's suggest
Sebastian Noack 2018/08/22 20:54:34 The canonical way to refer to a dependency's versi
tlucas 2018/08/23 08:47:27 Adjusted the pinnings. I also found a way to add
14 "selenium-webdriver": "^3.6.0" 18 "selenium-webdriver": "^3.6.0"
15 }, 19 },
16 "scripts": { 20 "scripts": {
17 "lint": "eslint *.js lib/ qunit/ ext/ test/", 21 "lint": "eslint *.js lib/ qunit/ ext/ test/",
18 "run_tests": "nodeunit test/*", 22 "pretest": "python build.py devenv -t gecko",
19 "test": "_run () { python build.py devenv -t $1; npm run run_tests ; } ; _ru n", 23 "test": "nodeunit test/*",
20 "posttest": "npm run lint" 24 "posttest": "npm run lint"
21 } 25 }
22 } 26 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld