Issue 6717 - Part 2: run qunit in headless firefox

test/firefox.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
 const FIREFOX_VERSION = "57.0";
 
 const path = require("path");
 const webdriver = require("selenium-webdriver");
 const {By, until} = webdriver;
 const firefox = require("selenium-webdriver/firefox");
 const {Command} = require("selenium-webdriver/lib/command");
 const {ensureFirefox} = require("../adblockpluscore/test/runners/" +
                                 "firefox_download");
 
-
 function reportElements(test, driver, success)
 {
   return driver.findElements(
-    By.css(`#qunit-tests ${success ? ".pass" : ".fail"} .test-name`)).

[Sebastian Noack, 2018/08/24 12:54:42]

Nit: (Same like in Python) please put closing parenthesis on a line with the
same indentation level as the line with the corresponding opening parenthesis.

  return driver.findElements(
    By.css(`#qunit-tests ${success ? ".pass" : ".fail"} .test-name`)
  ).then(elements => Promise.all(elements.map(elem =>
    elem.getAttribute("innerHTML").then(data => test.ok(success, data))
  )));

[tlucas, 2018/08/24 13:10:14]

Done.

-      then(elements => Promise.all(elements.map(elem =>
-        elem.getAttribute("innerHTML").then(data => test.ok(success, data)))));
+    By.css(`#qunit-tests ${success ? ".pass" : ".fail"} .test-name`)
+  ).then(elements => Promise.all(elements.map(elem =>
+    elem.getAttribute("innerHTML").then(data => test.ok(success, data))
+  )));
 }
 
 exports.runFirefox = function(test)
 {
   // https://stackoverflow.com/a/45045036
   function installWebExt(driver, extension)
   {
     let cmd = new Command("moz-install-web-ext")
       .setParameter("path", path.resolve(extension))
       .setParameter("temporary", true);
@@ skipping 44 matching lines @@
         driver.findElement(By.id("qunit-testresult"))
           .getAttribute("innerHTML").then(data =>
              data.includes("Tests completed")))
     ).then(() => Promise.all([
       reportElements(test, driver, true),
       reportElements(test, driver, false)
     ])).then(() =>
     {
       driver.quit();
       test.done();
-    }).catch((err) =>
-    {
+    }, err =>
       driver.quit().then(() =>
       {
         throw err;
-      });
-    });
+      })
+    );
   });
 };