Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(624)

Issue 29860568: Noissue - Check for escape characters in filter text before unescaping

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 weeks, 1 day ago by Manish Jethani
Modified:
4 weeks, 1 day ago
Reviewers:
sergei
CC:
kzar
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Given that searching for a single occurrence of a raw string is faster than doing a global replace with a regular expression, and out of ~82,000 filters there are only a small fraction that contain anything (literally only "[") that needs escaping, this should speed things up a little bit. In my tests this one line of code is ~10% faster now.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M lib/filterStorage.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
Manish Jethani
4 weeks, 1 day ago (2018-08-21 14:31:18 UTC) #1
Manish Jethani
4 weeks, 1 day ago (2018-08-21 14:35:15 UTC) #2
Patch Set 1
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5