test/filterStorage.js - Issue 29860589: Issue 6829 - Free filters when subscriptions are empty

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: test/filterStorage.js

Issue 29860589: Issue 6829 - Free filters when subscriptions are empty (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/

Patch Set: Address PS1 comment Created Aug. 30, 2018, 5:10 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: test/filterStorage.js

===================================================================

--- a/test/filterStorage.js

+++ b/test/filterStorage.js

@@ -490,11 +490,12 @@

compareFilterSubscriptions(test, "filter2 subscriptions after updating http://test3/ filters", filter2, [subscription2, subscription3]);

compareFilterSubscriptions(test, "filter3 subscriptions after updating http://test3/ filters", filter3, [subscription2]);

FilterStorage.removeSubscription(subscription3);

compareFilterSubscriptions(test, "filter1 subscriptions after removing http://test3/", filter1, []);

compareFilterSubscriptions(test, "filter2 subscriptions after removing http://test3/", filter2, [subscription2]);

compareFilterSubscriptions(test, "filter3 subscriptions after removing http://test3/", filter3, [subscription2]);

+ test.equal(Filter.knownFilters[filter1.text], undefined);

Jon Sonesen 2018/08/30 17:11:42 This test is currently a noop (removing changes do

test.done();

};

« no previous file with comments | « lib/filterStorage.js ('k') | no next file » | no next file with comments »