.gitlab-ci.yml - Issue 29862580: Issue 6651 - Pt1: Qunit tests through gitlab CI (PENDING)

Side by Side Diff: .gitlab-ci.yml

Issue 29862580: Issue 6651 - Pt1: Qunit tests through gitlab CI (PENDING) (Closed) Base URL: https://codereview.adblockplus.org/29860555/

Patch Set: Created Aug. 23, 2018, 7 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # This file is part of Adblock Plus <https://adblockplus.org/>,

	2 # Copyright (C) 2006-present eyeo GmbH

	3 #

	4 # Adblock Plus is free software: you can redistribute it and/or modify

	5 # it under the terms of the GNU General Public License version 3 as

	6 # published by the Free Software Foundation.

	7 #

	8 # Adblock Plus is distributed in the hope that it will be useful,

	9 # but WITHOUT ANY WARRANTY; without even the implied warranty of

	10 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

	11 # GNU General Public License for more details.

	12 #

	13 # You should have received a copy of the GNU General Public License

	14 # along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.

	15

	16 stages:

	17 - install

	18 - test_ext

	19

	20 .gecko_branch: &gecko_branch
	Sebastian Noack 2018/08/23 23:35:53 What does that do? What does that do? tlucas 2018/08/24 10:27:58 Removed now, but FWIW: this template (used as a v Show quoted text On 2018/08/23 23:35:53, Sebastian Noack wrote: > What does that do? Removed now, but FWIW: this template (used as a variable) was meant to keep the .yml dry (i.e. specify target branches for builds only once)
	21 only:

	22 - branches

	23

	24 prepare-dependencies:

	25 stage: install

	26 script:

	27 - mkdir -p .git/info && touch .git/info/exclude
	Sebastian Noack 2018/08/23 23:35:53 Perhaps we should rather adapt ensure_dependencies Perhaps we should rather adapt ensure_dependencies.py so that it doesn't attempt to setup the excludes if running from outside a repository. This would not only make this line redundant but also allows to run ensure_dependecies.py in other contexts (e.g. after unpacking the code from an archive file). tlucas 2018/08/24 10:27:58 While you're right about the perks, i'd rather not Show quoted text On 2018/08/23 23:35:53, Sebastian Noack wrote: > Perhaps we should rather adapt ensure_dependencies.py so that it doesn't attempt > to setup the excludes if running from outside a repository. This would not only > make this line redundant but also allows to run ensure_dependecies.py in other > contexts (e.g. after unpacking the code from an archive file). While you're right about the perks, i'd rather not initiate a change to the buildtools and a subsequent dependency update, when the only additional perk is nothing we desperately need / is not part of the prio directly. (FWIW the folder in question actually is a repository, it's just that .git/info is not created by the runners "git clone"/"git fetch" configuration)
	28 - pip install --user -r build_requirements.txt
	Sebastian Noack 2018/08/23 23:45:06 If the only purpose of the requirements file is to If the only purpose of the requirements file is to refer to it here and as long as it only contains a couple packages, I might rather inline the packages here. tlucas 2018/08/24 10:27:58 Done. Show quoted text On 2018/08/23 23:45:06, Sebastian Noack wrote: > If the only purpose of the requirements file is to refer to it here and as long > as it only contains a couple packages, I might rather inline the packages here. Done.
	29 - python ensure_dependencies.py

	30 - npm install

	31 cache:

	32 key: cache_$CI_COMMIT_SHA
	Sebastian Noack 2018/08/23 23:35:53 Is there any point in caching if the cache is inva Is there any point in caching if the cache is invalidated with every new commit anyway? tlucas 2018/08/24 10:27:58 Removed now, but FWIW: The cache is shared across Show quoted text On 2018/08/23 23:35:53, Sebastian Noack wrote: > Is there any point in caching if the cache is invalidated with every new commit > anyway? Removed now, but FWIW: The cache is shared across all the jobs inside a pipline with this key, meaning "ensure_dependencies.py" is only run once (best case, no guarantee) for the testing, building and deployment stages. Otherwise each job would freshly clone the repository and would have to execute the full cloning process from ensure_dependencies.py again.
	33 paths:

	34 - ./

	35 policy: push

	36

	37 # reusable template for browser-test jobs

	38 .browser_test_t: &browser_test

	39 stage: test_ext

	40 script:

	41 - npm test -- $TARGET

	42 cache:

	43 key: cache_$CI_COMMIT_SHA

	44 paths:

	45 - ./

	46 policy: pull

	47 environment:

	48 name: devbuilds

	49

	50 # Invoke browser tests

	51

	52 qunit:gecko:

	53 variables:

	54 TARGET: gecko
	Sebastian Noack 2018/08/23 23:35:53 Where is this variable picked up? Where is this variable picked up? tlucas 2018/08/24 10:27:58 Line 41, However, it's removed now. Show quoted text On 2018/08/23 23:35:53, Sebastian Noack wrote: > Where is this variable picked up? Line 41, However, it's removed now.
	55 <<: *browser_test

	56 <<: *gecko_branch

OLD	NEW

« no previous file with comments | « no previous file | build_requirements.txt » ('j') | build_requirements.txt » ('J')