.gitlab-ci.yml - Issue 29862580: Issue 6651 - Pt1: Qunit tests through gitlab CI (PENDING)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: .gitlab-ci.yml

Issue 29862580: Issue 6651 - Pt1: Qunit tests through gitlab CI (PENDING) (Closed) Base URL: https://codereview.adblockplus.org/29860555/

Patch Set: Created Aug. 24, 2018, 1:03 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # This file is part of Adblock Plus <https://adblockplus.org/>,

	2 # Copyright (C) 2006-present eyeo GmbH

	3 #

	4 # Adblock Plus is free software: you can redistribute it and/or modify

	5 # it under the terms of the GNU General Public License version 3 as

	6 # published by the Free Software Foundation.

	7 #

	8 # Adblock Plus is distributed in the hope that it will be useful,

	9 # but WITHOUT ANY WARRANTY; without even the implied warranty of

	10 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

	11 # GNU General Public License for more details.

	12 #

	13 # You should have received a copy of the GNU General Public License

	14 # along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.

	15

	16 stages:

	17 - test_ext
	sergei 2018/08/24 14:20:07 I'm also not sure that it's already time to introd I'm also not sure that it's already time to introduce stages, but it's fine for me.
	18

	19 qunit:gecko:

	20 stage: test_ext

	21 script:

	22 - mkdir -p .git/info

	23 - pip install --user Jinja2 cryptography
	sergei 2018/08/24 14:20:07 I would also think about adding of `pip install -U I would also think about adding of `pip install -U pip`. According to my experience, images of CI sometimes are not updated so often and as the result one gets complains about obsolete pip.
	24 - npm install
	sergei 2018/08/24 13:19:23 what about moving all these steps but `npm test` i what about moving all these steps but `npm test` into before_script? tlucas 2018/08/24 13:35:22 By the time we introduce more stages (building / d Show quoted text On 2018/08/24 13:19:23, sergei wrote: > what about moving all these steps but `npm test` into before_script? By the time we introduce more stages (building / deploying) to the CI/CD, those would be run for every job and severely slow down execution time. The solution for that is caching, so those steps will be removed from before_script later on anyway. sergei 2018/08/24 14:20:08 I personally don't find caching of such things as Show quoted text On 2018/08/24 13:35:22, tlucas wrote: > On 2018/08/24 13:19:23, sergei wrote: > > what about moving all these steps but `npm test` into before_script? > > By the time we introduce more stages (building / deploying) to the CI/CD, those > would be run for every job and severely slow down execution time. The solution > for that is caching, so those steps will be removed from before_script later on > anyway. I personally don't find caching of such things as a good idea, but it's up to any project team. Nevertheless, I proposed to create before_script for this particular job mainly for the sake of order and self-description. All these steps of preparing the environment should be separated from the actual actions, in this case from running the tests. I don't insist on it, it's just a good practice which is used in other projects, despite the everything could be in `script`. Do I correctly understand that a global before_script is executed for each job, thus several times? If so, then I think that one could add a stage "prepare" and just move the content of the current `before_script` to `script` of "prepare".
	25 - npm test

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »