Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29863579: Issue 6868 - Enable capturing of surrounding wildcards for rewrite filters (Closed)

Created:
Aug. 24, 2018, 4:36 p.m. by Manish Jethani
Modified:
Sept. 4, 2018, 3:38 p.m.
Reviewers:
hub
CC:
kzar
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Add comment in test file #

Total comments: 6

Patch Set 3 : Rebase #

Patch Set 4 : Rename to captureAll #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -9 lines) Patch
M lib/common.js View 1 2 3 1 chunk +19 lines, -8 lines 0 comments Download
M lib/filterClasses.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/filterClasses.js View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7
Manish Jethani
Aug. 24, 2018, 4:36 p.m. (2018-08-24 16:36:27 UTC) #1
Manish Jethani
Patch Set 1 Patch Set 2: Add comment in test file
Aug. 24, 2018, 4:45 p.m. (2018-08-24 16:45:24 UTC) #2
hub
https://codereview.adblockplus.org/29863579/diff/29863584/lib/common.js File lib/common.js (right): https://codereview.adblockplus.org/29863579/diff/29863584/lib/common.js#newcode43 lib/common.js:43: text = text.replace(/\*+/g, "*"); I think we should keep ...
Aug. 28, 2018, 10:02 p.m. (2018-08-28 22:02:55 UTC) #3
Manish Jethani
https://codereview.adblockplus.org/29863579/diff/29863584/lib/common.js File lib/common.js (right): https://codereview.adblockplus.org/29863579/diff/29863584/lib/common.js#newcode43 lib/common.js:43: text = text.replace(/\*+/g, "*"); On 2018/08/28 22:02:55, hub wrote: ...
Aug. 29, 2018, 1:25 p.m. (2018-08-29 13:25:25 UTC) #4
hub
https://codereview.adblockplus.org/29863579/diff/29863584/lib/common.js File lib/common.js (right): https://codereview.adblockplus.org/29863579/diff/29863584/lib/common.js#newcode38 lib/common.js:38: function filterToRegExp(text, optimize = true) also, on second thought, ...
Aug. 29, 2018, 4:23 p.m. (2018-08-29 16:23:50 UTC) #5
Manish Jethani
Patch Set 3: Rebase Patch Set 4: Rename to captureAll https://codereview.adblockplus.org/29863579/diff/29863584/lib/common.js File lib/common.js (right): https://codereview.adblockplus.org/29863579/diff/29863584/lib/common.js#newcode38 ...
Sept. 1, 2018, 2:57 p.m. (2018-09-01 14:57:52 UTC) #6
hub
Sept. 4, 2018, 3:30 p.m. (2018-09-04 15:30:46 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld