lib/filterClasses.js - Issue 29863579: Issue 6868 - Enable capturing of surrounding wildcards for rewrite filters

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: lib/filterClasses.js

Issue 29863579: Issue 6868 - Enable capturing of surrounding wildcards for rewrite filters (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/

Patch Set: Add comment in test file Created Aug. 24, 2018, 4:42 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/filterClasses.js

===================================================================

--- a/lib/filterClasses.js

+++ b/lib/filterClasses.js

@@ -657,17 +657,17 @@

regexpSource: null,

/**

* Regular expression to be used when testing against this filter

* @type {RegExp}

get regexp()

{

- let source = Filter.toRegExp(this.regexpSource);

+ let source = Filter.toRegExp(this.regexpSource, this.rewrite == null);

let regexp = new RegExp(source, this.matchCase ? "" : "i");

Object.defineProperty(this, "regexp", {value: regexp});

this.regexpSource = null;

return regexp;

/**

* Content types the filter applies to, combination of values from

* RegExpFilter.typeMap

« lib/common.js ('K') | « lib/common.js ('k') | test/filterClasses.js » ('j') | no next file with comments »