Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: toolkit/components/extensions/schemas/runtime.json

Issue 29863604: Issue 6865 - Update ABP dependency to version 3.2 (Closed)
Left Patch Set: Removing patch file Created Aug. 24, 2018, 8:41 p.m.
Right Patch Set: Adjusting code style Created Jan. 16, 2019, 1:45 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « toolkit/components/extensions/ext-c-runtime.js ('k') | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 [ 5 [
6 { 6 {
7 "namespace": "manifest", 7 "namespace": "manifest",
8 "types": [ 8 "types": [
9 { 9 {
10 "$extend": "Permission", 10 "$extend": "Permission",
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
152 } 152 }
153 }, 153 },
154 "id": { 154 "id": {
155 "type": "string", 155 "type": "string",
156 "allowedContexts": ["content", "devtools"], 156 "allowedContexts": ["content", "devtools"],
157 "description": "The ID of the extension/app." 157 "description": "The ID of the extension/app."
158 } 158 }
159 }, 159 },
160 "functions": [ 160 "functions": [
161 { 161 {
162 "name": "abbRegisterRequestListener", 162 "name": "registerAbbMessageListener",
163 "type": "function", 163 "type": "function",
164 "allowedContexts": ["content", "devtools"], 164 "description": "Function required to listen to Android messages. See htt ps://issues.adblockplus.org/ticket/6865",
Thomas Greiner 2018/08/27 15:24:42 From what I understood we only need to communicate
diegocarloslima 2018/08/27 21:19:17 If I dont add at least the 'content' context, I ca
Thomas Greiner 2018/08/28 10:36:07 That's odd because "content" seems to refer to con
165 "description": "Function required to listen to Android requests. See htt ps://issues.adblockplus.org/ticket/6865",
Thomas Greiner 2018/08/27 15:24:42 Suggestion: The naming confused me at first becaus
diegocarloslima 2018/08/27 21:19:17 I will rename 'abbSendRequest' to 'sendAbbMessage'
Thomas Greiner 2018/08/28 10:36:07 Sounds good. :)
166 "parameters": [ 165 "parameters": [
167 { 166 {
168 "name": "listener", 167 "name": "listener",
169 "type": "function" 168 "type": "function"
170 } 169 }
171 ] 170 ]
172 }, 171 },
173 { 172 {
174 "name": "abbSendRequest", 173 "name": "sendAbbMessage",
175 "type": "function", 174 "type": "function",
176 "allowedContexts": ["content", "devtools"], 175 "description": "Function required to send messages to Android. See https ://issues.adblockplus.org/ticket/6865",
177 "description": "Function required to send requests to Android. See https ://issues.adblockplus.org/ticket/6865",
178 "parameters": [ 176 "parameters": [
179 { 177 {
180 "name": "type", 178 "name": "type",
181 "type": "string" 179 "type": "string"
182 } 180 }
183 ] 181 ]
184 }, 182 },
185 { 183 {
186 "name": "getBackgroundPage", 184 "name": "getBackgroundPage",
187 "type": "function", 185 "type": "function",
(...skipping 423 matching lines...) Expand 10 before | Expand all | Expand 10 after
611 { 609 {
612 "$ref": "OnRestartRequiredReason", 610 "$ref": "OnRestartRequiredReason",
613 "name": "reason", 611 "name": "reason",
614 "description": "The reason that the event is being dispatched." 612 "description": "The reason that the event is being dispatched."
615 } 613 }
616 ] 614 ]
617 } 615 }
618 ] 616 ]
619 } 617 }
620 ] 618 ]
LEFTRIGHT

Powered by Google App Engine
This is Rietveld