Issue 6882 - always shutdown the browser gracefully

test/firefox.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 76 matching lines @@
       driver.wait(until.elementLocated(By.id("qunit-testresult")))
     ).then(() =>
       // Wait for tests to finish
       driver.wait(() =>
         driver.findElement(By.id("qunit-testresult"))
           .getAttribute("innerHTML").then(data =>
              data.includes("Tests completed")))
     ).then(() => Promise.all([
       reportElements(test, driver, true),
       reportElements(test, driver, false)
-    ])).then(() =>
-    {
-      driver.quit();
-      test.done();
-    }, err =>
-      driver.quit().then(() =>
-      {
-        throw err;
-      })
+    ])).then(
+      () => driver.quit().then(() => test.done()),
+      err => driver.quit().then(() => { throw err; })

[tlucas, 2018/08/25 09:36:01]

Our coding-style (https://adblockplus.org/en/coding-style @ "General") tells us
to always put opening braces on their own line.

I looked for exceptions, but found none. Do we practice this even in this case,
where newlines would unnecessarily (imho) mess up readability?

[Sebastian Noack, 2018/08/25 09:51:38]

One liners are fine too.

     );
   });
 };