Issue 6884 - Migrate from nodeunit to mocha

test/firefox.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 51 matching lines @@
       return driver.wait(() =>
         driver.getAllWindowHandles().then(handles => handles[1])
       ).then(handle =>
         driver.switchTo().window(handle)
       ).then(() =>
         driver.executeScript("return location.origin;")
       ).then(result => { origin = result; });
     })
   );
 
-  function reportElements(success)
-  {
-    return driver.findElements(
-      By.css(`#qunit-tests ${success ? ".pass" : ".fail"} .test-name`)
-    ).then(elements => Promise.all(elements.map(elem =>
-      elem.getAttribute("textContent").then(data => assert.ok(success, data))

[Sebastian Noack, 2018/08/26 19:02:00]

While changing this code anyway, I now, also use textContent instead of
innerHTML in order to avoid markup from potentially being printed.

[tlucas, 2018/08/26 21:13:50]

Acknowledged.

-    )));
-  }
-
   it("qunit", () =>
     driver.navigate().to(origin + "/qunit/index.html").then(() =>
       // Wait for qunit-results to be present
       driver.wait(until.elementLocated(By.id("qunit-testresult")))
     ).then(() =>
       // Wait for tests to finish
       driver.wait(() =>
         driver.findElement(By.id("qunit-testresult"))
           .getAttribute("innerHTML").then(data =>
              data.includes("Tests completed")))
-    ).then(() => Promise.all([
-      reportElements(true),
-      reportElements(false)
-    ]))
+    ).then(() => Promise.all([[true, ".pass"], [false, ".fail"]].map(
+      ([success, sel]) => driver.findElements(
+        By.css(`#qunit-tests ${sel} .test-name`)
+      ).then(elements => Promise.all(elements.map(elem =>
+        elem.getAttribute("textContent").then(data => assert.ok(success, data))
+      )))
+    )))
   );
 
   after(() => driver.quit());
 });