Issue 6886 - Return snippet filters instead of just scripts

lib/snippets.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 43 matching lines @@
   /**
    * Removes a snippet filter
    * @param {SnippetFilter} filter
    */
   remove(filter)
   {
     filters.delete(filter.text);
   },
 
   /**
-   * Returns a list of all scripts active on a particular domain
+   * Returns a list of all snippet filters active on a particular domain
    * @param {string} domain
-   * @return {string[]}
+   * @return {Filter[]}

[Manish Jethani, 2018/08/27 05:59:13]

As in the rest of the file we can be more specific here. Let's make it `@returns
{Array.<SnippetFilter>}` here.

[hub, 2018/08/27 12:14:35]

Done.

    */
-  getScriptsForDomain(domain)
+  getSnippetsForDomain(domain)

[Manish Jethani, 2018/08/27 05:40:10]

Let's just call this `getFiltersForDomain`. Currently we have
`ElemHide.getSelectorsForDomain` (returns selectors),
`ElemHideEmulation.getRulesForDomain` (returns filters), and
`Snippets.getScriptsForDomain` (returns scripts). We will have to merge these at
some point and the only generic name one can come up with is
`getFiltersForDomain`, where the name of the module (i.e. `Snippets` in this
case) implies the kinds of filters that are returned.

[hub, 2018/08/27 12:14:35]

Done.

   {
     let result = [];
     for (let text of filters)
     {
       let filter = Filter.fromText(text);
       if (filter.isActiveOnDomain(domain))
-        result.push(filter.script);
+        result.push(filter);
     }
     return result;
   }
 };
 
 exports.Snippets = Snippets;
 
 /**
  * Parses a script and returns a list of all its commands and their arguments
  * @param {string} script
@@ skipping 102 matching lines @@
           let value = imports[name];
           if (typeof value == "function")
             value(...args);
         }
       }
     }
   `;
 }
 
 exports.compileScript = compileScript;