Issue 6886 - Return snippet filters instead of just scripts

test/snippets.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 30 matching lines @@
 exports.testDomainRestrictions = function(test)
 {
   function testScriptMatches(description, filters, domain, expectedMatches)
   {
     for (let filter of filters.map(Filter.fromText))
     {
       if (filter instanceof SnippetFilter)
         Snippets.add(filter);
     }
 
-    let matches = Snippets.getScriptsForDomain(domain);
-    test.deepEqual(matches.sort(), expectedMatches.sort(), description);
+    let matches = Snippets.getSnippetsForDomain(domain);

[Manish Jethani, 2018/08/27 05:40:10]

I think it would be cleaner to keep the call to `test.deepEqual` free of this
additional mapping, so perhaps we could do this:

  let matches = Snippets.getFiltersForDomain(domain).map(({script}) => script);

[hub, 2018/08/27 12:14:35]

Done.

+    test.deepEqual(matches.map(elem => elem.script).sort(), expectedMatches.sort(), description);
 
     Snippets.clear();
   }
 
   testScriptMatches(
     "Ignore generic filters",
     [
       "#$#foo-1", "example.com#$#foo-2",
       "~example.com#$#foo-3"
     ],
@@ skipping 18 matching lines @@
     ["foo-2"]
   );
 
   test.done();
 };
 
 exports.testSnippetFiltersContainer = function(test)
 {
   function compareRules(description, domain, expectedMatches)
   {
-    let result = Snippets.getScriptsForDomain(domain);
-    expectedMatches = expectedMatches.map(filter => filter.script);
+    let result = Snippets.getSnippetsForDomain(domain);
     test.deepEqual(result.sort(), expectedMatches.sort(), description);
   }
 
   let domainFilter = Filter.fromText("example.com#$#filter1");
   let subdomainFilter = Filter.fromText("www.example.com#$#filter2");
   let otherDomainFilter = Filter.fromText("other.example.com#$#filter3");
 
   Snippets.add(domainFilter);
   Snippets.add(subdomainFilter);
   Snippets.add(otherDomainFilter);
@@ skipping 178 matching lines @@
   // between executions. In the example below, assertFoo does not find 456 but
   // it doesn't find 123 either. It's the initial value 0.
   new Function(
     compileScript("setFoo 456; assertFoo 0", [
       ...libraries, "let foo = 1; exports.setFoo = value => { foo = value; };"
     ])
   )();
 
   test.done();
 };