dependencies - Issue 29865587: Issue 6843 - Log snippet filter hits

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: dependencies

Issue 29865587: Issue 6843 - Log snippet filter hits (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/

Left Patch Set: fixed wrapping Created Aug. 27, 2018, 7:45 p.m.

Right Patch Set: rebased on top of issue 6889 Created Aug. 28, 2018, 3:14 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/	1 _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/

2 _self = buildtools/ensure_dependencies.py	2 _self = buildtools/ensure_dependencies.py

3 buildtools = buildtools hg:1b51de5f632c git:444c380	3 buildtools = buildtools hg:1b51de5f632c git:444c380

4 adblockpluscore = adblockpluscore hg:6ad6dd7c2ff1 git:b4a3d60	4 adblockpluscore = adblockpluscore hg:6ad6dd7c2ff1 git:b4a3d60
Manish Jethani 2018/08/27 20:40:59 About this, see my comment here: https://issues.a About this, see my comment here: https://issues.adblockplus.org/ticket/6843#comment:12 We need to make a change in lib/whitelisting.js as well. Maybe we have to do this in two separate steps, I'm not sure. hub 2018/08/27 21:14:26 Filed https://issues.adblockplus.org/ticket/6889 Show quoted text On 2018/08/27 20:40:59, Manish Jethani wrote: > About this, see my comment here: > > https://issues.adblockplus.org/ticket/6843#comment:12 > > We need to make a change in lib/whitelisting.js as well. Maybe we have to do > this in two separate steps, I'm not sure. Filed https://issues.adblockplus.org/ticket/6889
5 adblockplusui = adblockplusui hg:3b97a00a1189 git:e4c4803	5 adblockplusui = adblockplusui hg:3b97a00a1189 git:e4c4803

LEFT	RIGHT