Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(56)

Issue 29866577: Issue 6887 - add Chrome to "npm test" (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 2 months ago by tlucas
Modified:
1 year, 2 months ago
Reviewers:
Sebastian Noack
CC:
kzar, hub, sergei
Visibility:
Public.

Description

Issue 6887 - add Chrome to "npm test"

Patch Set 1 #

Total comments: 38

Patch Set 2 : #

Total comments: 8

Patch Set 3 : #

Total comments: 10

Patch Set 4 : #

Total comments: 9

Patch Set 5 : #

Total comments: 6

Patch Set 6 : #

Patch Set 7 : Removed unused this.platform #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -99 lines) Patch
M README.md View 1 1 chunk +7 lines, -3 lines 0 comments Download
M package.json View 1 2 2 chunks +7 lines, -3 lines 0 comments Download
A + test/.eslintrc.json View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A test/all.js View 1 2 3 4 5 6 1 chunk +81 lines, -0 lines 0 comments Download
A test/browsers/chromium.js View 1 2 3 4 5 1 chunk +50 lines, -0 lines 0 comments Download
A test/browsers/firefox.js View 1 2 3 4 5 1 chunk +56 lines, -0 lines 0 comments Download
D test/firefox.js View 1 chunk +0 lines, -92 lines 0 comments Download
A test/wrappers/qunit.js View 1 2 3 4 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 14
tlucas
1 year, 2 months ago (2018-08-27 15:10:13 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29866577/diff/29866578/package.json File package.json (right): https://codereview.adblockplus.org/29866577/diff/29866578/package.json#newcode10 package.json:10: "The chromedriver version was pinned to that exact version, ...
1 year, 2 months ago (2018-08-27 19:56:16 UTC) #2
tlucas
Patch Set 2: * Address Sebastian's comments. https://codereview.adblockplus.org/29866577/diff/29866578/package.json File package.json (right): https://codereview.adblockplus.org/29866577/diff/29866578/package.json#newcode10 package.json:10: "The chromedriver ...
1 year, 2 months ago (2018-08-28 08:18:15 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29866577/diff/29866578/package.json File package.json (right): https://codereview.adblockplus.org/29866577/diff/29866578/package.json#newcode10 package.json:10: "The chromedriver version was pinned to that exact version, ...
1 year, 2 months ago (2018-08-28 14:44:58 UTC) #4
tlucas
https://codereview.adblockplus.org/29866577/diff/29866578/package.json File package.json (right): https://codereview.adblockplus.org/29866577/diff/29866578/package.json#newcode10 package.json:10: "The chromedriver version was pinned to that exact version, ...
1 year, 2 months ago (2018-08-29 09:16:54 UTC) #5
Sebastian Noack
https://codereview.adblockplus.org/29866577/diff/29866578/test/run.js File test/run.js (right): https://codereview.adblockplus.org/29866577/diff/29866578/test/run.js#newcode71 test/run.js:71: it(testModule.title, () => On 2018/08/29 09:16:53, tlucas wrote: > ...
1 year, 2 months ago (2018-08-29 15:22:12 UTC) #6
Sebastian Noack
https://codereview.adblockplus.org/29866577/diff/29868558/test/all.js File test/all.js (right): https://codereview.adblockplus.org/29866577/diff/29868558/test/all.js#newcode37 test/all.js:37: before(() => new Promise((resolve, reject) => I just noticed, ...
1 year, 2 months ago (2018-08-30 02:02:40 UTC) #7
tlucas
https://codereview.adblockplus.org/29866577/diff/29866578/test/run.js File test/run.js (right): https://codereview.adblockplus.org/29866577/diff/29866578/test/run.js#newcode71 test/run.js:71: it(testModule.title, () => On 2018/08/29 15:22:12, Sebastian Noack wrote: ...
1 year, 2 months ago (2018-09-01 09:38:31 UTC) #8
Sebastian Noack
https://codereview.adblockplus.org/29866577/diff/29868558/test/all.js File test/all.js (right): https://codereview.adblockplus.org/29866577/diff/29868558/test/all.js#newcode37 test/all.js:37: before(() => new Promise((resolve, reject) => On 2018/09/01 09:38:31, ...
1 year, 2 months ago (2018-09-01 10:42:48 UTC) #9
tlucas
Patch Set 5: * Address Sebastian's comments https://codereview.adblockplus.org/29866577/diff/29868558/test/all.js File test/all.js (right): https://codereview.adblockplus.org/29866577/diff/29868558/test/all.js#newcode37 test/all.js:37: before(() => ...
1 year, 2 months ago (2018-09-01 11:54:24 UTC) #10
Sebastian Noack
https://codereview.adblockplus.org/29866577/diff/29868558/test/all.js File test/all.js (right): https://codereview.adblockplus.org/29866577/diff/29868558/test/all.js#newcode37 test/all.js:37: before(() => new Promise((resolve, reject) => On 2018/09/01 11:54:23, ...
1 year, 2 months ago (2018-09-01 12:26:34 UTC) #11
Sebastian Noack
https://codereview.adblockplus.org/29866577/diff/29871566/test/all.js File test/all.js (right): https://codereview.adblockplus.org/29866577/diff/29871566/test/all.js#newcode73 test/all.js:73: require(path.resolve(file)); You call path.resolve() twice here. Perhaps use a ...
1 year, 2 months ago (2018-09-01 12:28:11 UTC) #12
tlucas
https://codereview.adblockplus.org/29866577/diff/29868558/test/all.js File test/all.js (right): https://codereview.adblockplus.org/29866577/diff/29868558/test/all.js#newcode37 test/all.js:37: before(() => new Promise((resolve, reject) => On 2018/09/01 12:26:33, ...
1 year, 2 months ago (2018-09-01 14:46:46 UTC) #13
Sebastian Noack
1 year, 2 months ago (2018-09-01 15:13:26 UTC) #14
LGTM!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5