package.json - Issue 29866577: Issue 6887 - add Chrome to "npm test"

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: package.json

Issue 29866577: Issue 6887 - add Chrome to "npm test" (Closed)

Patch Set: Created Aug. 28, 2018, 8:17 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 {	1 {

2 "name": "adblockpluschrome",	2 "name": "adblockpluschrome",

3 "repository": "https://hg.adblockplus.org/adblockpluschrome",	3 "repository": "https://hg.adblockplus.org/adblockpluschrome",

4 "license": "GPL-3.0",	4 "license": "GPL-3.0",

5 "dependencies": {},	5 "dependencies": {},

6 "devDependencies": {	6 "devDependencies": {

7 "//": [	7 "//": [

8 "'dmg', 'extract-zip' and 'ncp' are needed by the module",	8 "'dmg', 'extract-zip' and 'ncp' are needed by `download_*.js` modules",

9 "adblockpluscore/test/download_firefox.js."	9 "in adblockpluscore/test/.",

	10 "The chromedriver version was pinned to that exact version, due tu in-",

	11 "compatibilities with the configured chromium version and newer drivers."

10 ],	12 ],

	13 "chromedriver": "2.36.0",

11 "dmg": "^0.1.0",	14 "dmg": "^0.1.0",

12 "eslint": "^5.1.0",	15 "eslint": "^5.1.0",

13 "eslint-config-eyeo": "^2.1.0",	16 "eslint-config-eyeo": "^2.1.0",

14 "extract-zip": "^1.6.5",	17 "extract-zip": "^1.6.5",

15 "geckodriver": "^1.9.0",	18 "geckodriver": "^1.9.0",

16 "ncp": "^2.0.0",	19 "ncp": "^2.0.0",

17 "mocha": "^5.2.0",	20 "mocha": "^5.2.0",

18 "selenium-webdriver": "^3.6.0"	21 "selenium-webdriver": "^3.6.0"

19 },	22 },

20 "scripts": {	23 "scripts": {

21 "lint": "eslint *.js lib/ qunit/ ext/ test/",	24 "lint": "eslint *.js lib/ qunit/ ext/ test/",

22 "pretest": "python build.py devenv -t gecko",
Sebastian Noack 2018/08/28 14:44:58 As mentioned on the other review, we might want to As mentioned on the other review, we might want to call ensure_depdencies.py here. Previously, it was implicitly called by build.py, but at the time we call build.py now, we have already imported some code from adblockpluscore. tlucas 2018/08/29 09:16:53 Done. Show quoted text On 2018/08/28 14:44:58, Sebastian Noack wrote: > As mentioned on the other review, we might want to call ensure_depdencies.py > here. Previously, it was implicitly called by build.py, but at the time we call > build.py now, we have already imported some code from adblockpluscore. Done.
23 "test": "mocha",	25 "test": "mocha",

24 "posttest": "npm run lint"	26 "posttest": "npm run lint"

25 }	27 }

26 }	28 }

OLD	NEW

« no previous file with comments | « README.md ('k') | test/all.js » ('j') | test/all.js » ('J')