Issue 6887 - add Chrome to "npm test"

test/all.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-/* eslint-env mocha */
-
 "use strict";
 
 const glob = require("glob");
 const path = require("path");
 const {exec} = require("child_process");
 
 for (let browser of glob.sync("./test/browsers/*.js"))
 {
   let module = require(path.resolve(browser));
 
   describe(module.platform, function()
   {
     this.timeout(0);
 
-    let driver;
-    let origin;
-
-    before(() =>
-      new Promise((resolve, reject) =>
+    before(function()
+    {
+      return Promise.all([
+        module.ensureBrowser(),
+        new Promise((resolve, reject) =>
+        {
+          exec(`python build.py devenv -t ${module.platform}`,
+            (error, stdout, stderr) =>
+            {
+              if (error)
+              {
+                console.error(stderr);
+                reject(error);
+              }
+              else resolve(stdout);
+            });
+        })
+      ]).then(([browserBinary]) =>
       {
-        exec(`python build.py devenv -t ${module.platform}`,
-          (error, stdout, stderr) =>
-          {
-            if (error)
-            {
-              console.error(error);
-              reject(stderr);

[Sebastian Noack, 2018/08/28 14:44:58]

It seems you got it the wrong way around. You want to log the output you got on
stderr and propagate the error argument down the promise chain.

[tlucas, 2018/08/29 09:16:53]

Done.

-            }
-            else resolve(stdout);
-          });
-      }
-    ).then(() =>

[Sebastian Noack, 2018/08/28 14:44:58]

Nit: The indention is off here. Closing parenthesis go on a line with the same
level of indentation as the line with the respective opening parenthesis. Then
the newline is redundant as well.

[tlucas, 2018/08/29 09:16:53]

re indented here and above (at "new Promise") 

-      module.getDriver().then(d =>
-      {
-        driver = d;
-        return driver.wait(() =>
-          driver.getAllWindowHandles().then(handles => handles[1])
+        this.driver = module.getDriver(
+          browserBinary,
+          path.resolve(`./devenv.${module.platform}`)
+        );
+        return this.driver.wait(() =>
+          this.driver.getAllWindowHandles().then(handles => handles[1])
         );
       }).then(handle =>
-        driver.switchTo().window(handle)
+        this.driver.switchTo().window(handle)
       ).then(() =>
-        driver.executeScript("return location.origin;")
-      ).then(o =>
+        this.driver.executeScript("return location.origin;")
+      ).then(origin =>
       {
-        origin = o;
-      })
-    ));
+        this.origin = origin;
+      });
+    });
 
     for (let file of glob.sync("./test/wrappers/*.js"))
     {
-      let testModule = require(path.resolve(file));
-
-      it(testModule.title, () =>
-      {
-        return testModule.it(driver, origin);
-      });
+      // Reload the module(s) for every browser
+      let modulePath = path.resolve(file);
+      delete require.cache[require.resolve(modulePath)];
+      require(modulePath);
     }
 
-    after(() => driver.quit());
+    after(function()
+    {
+      this.driver.quit();
+    });
   });
 }