Issue 6887 - add Chrome to "npm test"

test/all.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 28 matching lines @@
             (error, stdout, stderr) =>
             {
               if (error)
               {
                 console.error(stderr);
                 reject(error);
               }
               else resolve(stdout);
             });
         })
-      ]).then(data =>
+      ]).then(([browserBinary]) =>
       {
         this.driver = module.getDriver(
-          data[0],
+          browserBinary,
           path.resolve(`./devenv.${module.platform}`)
         );
         return this.driver.wait(() =>
           this.driver.getAllWindowHandles().then(handles => handles[1])
         );
       }).then(handle =>
         this.driver.switchTo().window(handle)
       ).then(() =>
         this.driver.executeScript("return location.origin;")
       ).then(origin =>
       {
         this.origin = origin;
-        this.platform = module.platform;
       });
     });
 
     for (let file of glob.sync("./test/wrappers/*.js"))
     {
       // Reload the module(s) for every browser
-      delete require.cache[require.resolve(path.resolve(file))];
-      require(path.resolve(file));

[Sebastian Noack, 2018/09/01 12:28:10]

You call path.resolve() twice here. Perhaps use a variable?

[tlucas, 2018/09/01 14:46:44]

Done.

+      let modulePath = path.resolve(file);
+      delete require.cache[require.resolve(modulePath)];
+      require(modulePath);
     }
 
     after(function()
     {
       this.driver.quit();
     });
   });
 }