test/browsers/chromium.js - Issue 29866577: Issue 6887 - add Chrome to "npm test"

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: test/browsers/chromium.js

Issue 29866577: Issue 6887 - add Chrome to "npm test" (Closed)

Left Patch Set: Created Sept. 1, 2018, 11:51 a.m.

Right Patch Set: Removed unused this.platform Created Sept. 1, 2018, 3:12 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 /*	1 /*

2 * This file is part of Adblock Plus <https://adblockplus.org/>,	2 * This file is part of Adblock Plus <https://adblockplus.org/>,

3 * Copyright (C) 2006-present eyeo GmbH	3 * Copyright (C) 2006-present eyeo GmbH

4 *	4 *

5 * Adblock Plus is free software: you can redistribute it and/or modify	5 * Adblock Plus is free software: you can redistribute it and/or modify

6 * it under the terms of the GNU General Public License version 3 as	6 * it under the terms of the GNU General Public License version 3 as

7 * published by the Free Software Foundation.	7 * published by the Free Software Foundation.

8 *	8 *

9 * Adblock Plus is distributed in the hope that it will be useful,	9 * Adblock Plus is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

(...skipping 18 matching lines...) Expand all Loading...
29 const {ensureChromium} = require("../../adblockpluscore/test/runners/" +	29 const {ensureChromium} = require("../../adblockpluscore/test/runners/" +

30 "chromium_download");	30 "chromium_download");

31	31

32 exports.platform = "chrome";	32 exports.platform = "chrome";

33	33

34 exports.ensureBrowser = function()	34 exports.ensureBrowser = function()

35 {	35 {

36 return ensureChromium(CHROMIUM_REVISION);	36 return ensureChromium(CHROMIUM_REVISION);

37 };	37 };

38	38

39 exports.getDriver = function(browserBinary, devenvPathAbsolute)	39 exports.getDriver = function(browserBinary, devenvPath)
Sebastian Noack 2018/09/01 12:26:34 Nit: I don't think that the path is absolute is an Nit: I don't think that the path is absolute is an important enough detail to bloat the argument name. I'd just call it "devenvPath". tlucas 2018/09/01 14:46:44 Done. Show quoted text On 2018/09/01 12:26:34, Sebastian Noack wrote: > Nit: I don't think that the path is absolute is an important enough detail to > bloat the argument name. I'd just call it "devenvPath". Done.
40 {	40 {

41 let options = new chrome.Options()	41 let options = new chrome.Options()

42 .setChromeBinaryPath(browserBinary)	42 .setChromeBinaryPath(browserBinary)

43 .addArguments("--no-sandbox")	43 .addArguments("--no-sandbox")

44 .addArguments(`load-extension=${devenvPathAbsolute}`);	44 .addArguments(`load-extension=${devenvPath}`);

45	45

46 return new webdriver.Builder()	46 return new webdriver.Builder()

47 .forBrowser("chrome")	47 .forBrowser("chrome")

48 .setChromeOptions(options)	48 .setChromeOptions(options)

49 .build();	49 .build();

50 };	50 };

LEFT	RIGHT