Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: package.json

Issue 29866577: Issue 6887 - add Chrome to "npm test" (Closed)
Patch Set: Created Aug. 27, 2018, 3:09 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/browser/chrome.js » ('j') | test/browser/chrome.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: package.json
diff --git a/package.json b/package.json
index fe9a51b3b85498ad037bdb07c31090a76e962dd4..6a68b8e13c21e62f7f5b352ca847f77dc7758cb1 100644
--- a/package.json
+++ b/package.json
@@ -5,9 +5,12 @@
"dependencies": {},
"devDependencies": {
"//": [
- "'dmg', 'extract-zip' and 'ncp' are needed by the module",
- "adblockpluscore/test/download_firefox.js."
+ "'dmg', 'extract-zip' and 'ncp' are needed by `download_*.js` modules",
+ "in adblockpluscore/test/.",
+ "The chromedriver version was pinned to that exact version, due tu in-",
Sebastian Noack 2018/08/27 19:56:15 Typo: It's "due to incompatibilities".
tlucas 2018/08/28 08:18:13 That's exactly what's written here?... Or do you m
Sebastian Noack 2018/08/28 14:44:57 It's not. What's written here is "due tu in-compat
tlucas 2018/08/29 09:16:53 Done.
+ "compatibilities with the configured chromium version and newer drivers."
],
+ "chromedriver": "2.36.0",
"dmg": "^0.1.0",
"eslint": "^5.1.0",
"eslint-config-eyeo": "^2.1.0",
@@ -19,7 +22,6 @@
},
"scripts": {
"lint": "eslint *.js lib/ qunit/ ext/ test/",
- "pretest": "python build.py devenv -t gecko",
"test": "mocha",
"posttest": "npm run lint"
}
« no previous file with comments | « no previous file | test/browser/chrome.js » ('j') | test/browser/chrome.js » ('J')

Powered by Google App Engine
This is Rietveld