Noissue - Check for comment indicator first while parsing filter text

lib/filterClasses.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 105 matching lines @@
  *
  * @param {string} text   as in Filter()
  * @return {Filter}
  */
 Filter.fromText = function(text)
 {
   let filter = Filter.knownFilters.get(text);
   if (filter)
     return filter;
 
-  let match = text.includes("#") ? Filter.contentRegExp.exec(text) : null;
-  if (match)
-    filter = ContentFilter.fromText(text, match[1], match[2], match[3]);
-  else if (text[0] == "!")
+  if (text[0] == "!")

[Jon Sonesen, 2018/08/29 15:01:36]

Is there any difference performance wise between this and <string>.startsWith()?

[Manish Jethani, 2018/08/29 15:50:15]

In my tests, which was a while ago, I had found that just checking for the first
character this way is faster than using `startsWith`.

+  {
     filter = new CommentFilter(text);
+  }
   else
-    filter = RegExpFilter.fromText(text);
+  {
+    let match = text.includes("#") ? Filter.contentRegExp.exec(text) : null;
+    if (match)
+      filter = ContentFilter.fromText(text, match[1], match[2], match[3]);
+    else
+      filter = RegExpFilter.fromText(text);
+  }
 
   Filter.knownFilters.set(filter.text, filter);
   return filter;
 };
 
 /**
  * Deserializes a filter
  *
  * @param {Object}  obj map of serialized properties and their values
  * @return {Filter} filter or null if the filter couldn't be created
@@ skipping 1034 matching lines @@
 
   /**
    * Script that should be executed
    * @type {string}
    */
   get script()
   {
     return this.body;
   }
 });