Issue 6890 - run npm tests in parallel (PENDING)

.gitlab-ci.yml

 # This file is part of Adblock Plus <https://adblockplus.org/>,
 # Copyright (C) 2006-present eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
 #
 # You should have received a copy of the GNU General Public License
 # along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
 
 stages:
   - prepare
   - test
 
-prepare-dependencies:
-  stage: prepare
-  script:
+.dependencies:
+  script: &dependencies
     - mkdir -p .git/info
     - pip install --user Jinja2 cryptography
     - python ensure_dependencies.py
-    - npm install
-  cache:
-    key: cache_$CI_COMMIT_SHA

[wspee, 2018/08/29 08:39:47]

IDEA: Have you thought about using a hash of the dependencies as a cache key
instead of the commit hash i.e. hash dependencies, add python dependencies to
the repository via a `dependencies.txt` or similar (like you had in previous
versions) and whatever else needs to be considered?

[tlucas, 2018/09/03 09:54:45]

I guess this would work - but IMHO not feasible right now

[Sebastian Noack, 2018/09/03 19:37:35]

I kinda like that idea, but I'm not too familiar with the capabilities of GitLab
CI configuration. However, if we could simply run a command here to derive the
cache key, this seems to be as simple as:

  cat dependencies package.json | sha1sum | awk '{ print $1 }'

[tlucas, 2018/09/03 21:35:53]

Turns out - unfortunately - that we can't use commands for the key, only
variables (gitlab specific or predefined from the project settings, but also
none exported from within the job)

-    paths:
-      - ./
-    policy: push
-
+    - "[ -d node_modules ] || npm install"
 
 .test_template: &test_template
   stage: test
-  before_script:
-    - python ensure_dependencies.py
-    - npm install
+  before_script: *dependencies
   cache:
     key: cache_$CI_COMMIT_SHA
     paths:
       - ./
     policy: pull
 
 
+prepare-dependencies:
+  stage: prepare
+  script: *dependencies
+  cache:
+    key: cache_$CI_COMMIT_SHA
+    paths:
+      - ./
+    policy: push
+
 tests:gecko:
   <<: *test_template
   script:
-    - npm test -- -g gecko
+    - npm run test-only -- -g gecko
 
 tests:chrome:
   <<: *test_template
   script:
-    - xvfb-run npm test -- -g chrome
+    - xvfb-run npm run test-only -- -g chrome
 
-tests:global:

[Sebastian Noack, 2018/08/29 21:03:11]

This isn't quite "testing" we are doing here, "lint" seems to be a a better name
for this job.

[tlucas, 2018/09/03 09:54:45]

Done.

+lint:
   <<: *test_template
   script:
     - npm run lint