Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: .gitlab-ci.yml

Issue 29867566: Issue 6890 - run npm tests in parallel (PENDING) (Closed) Base URL: https://codereview.adblockplus.org/29862580/
Left Patch Set: Created Sept. 3, 2018, 9:32 p.m.
Right Patch Set: Created Sept. 4, 2018, 7:18 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | package.json » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 # This file is part of Adblock Plus <https://adblockplus.org/>, 1 # This file is part of Adblock Plus <https://adblockplus.org/>,
2 # Copyright (C) 2006-present eyeo GmbH 2 # Copyright (C) 2006-present eyeo GmbH
3 # 3 #
4 # Adblock Plus is free software: you can redistribute it and/or modify 4 # Adblock Plus is free software: you can redistribute it and/or modify
5 # it under the terms of the GNU General Public License version 3 as 5 # it under the terms of the GNU General Public License version 3 as
6 # published by the Free Software Foundation. 6 # published by the Free Software Foundation.
7 # 7 #
8 # Adblock Plus is distributed in the hope that it will be useful, 8 # Adblock Plus is distributed in the hope that it will be useful,
9 # but WITHOUT ANY WARRANTY; without even the implied warranty of 9 # but WITHOUT ANY WARRANTY; without even the implied warranty of
10 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 10 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 # GNU General Public License for more details. 11 # GNU General Public License for more details.
12 # 12 #
13 # You should have received a copy of the GNU General Public License 13 # You should have received a copy of the GNU General Public License
14 # along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 14 # along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
15 15
16 stages: 16 stages:
17 - prepare 17 - prepare
18 - test 18 - test
19 19
20 .dependencies: 20 .dependencies:
tlucas 2018/09/03 21:35:54 I noticed that i only cache nodejs and adblockplus
21 script: &dependencies 21 script: &dependencies
22 - mkdir -p .git/info 22 - mkdir -p .git/info
23 - pip install --user Jinja2 cryptography 23 - pip install --user Jinja2 cryptography
24 - python ensure_dependencies.py 24 - python ensure_dependencies.py
25 - if [ ! -d "node_modules" ]; then npm install; fi 25 - "[ -d node_modules ] || npm install"
Sebastian Noack 2018/09/03 21:57:47 This could be done simpler: [ -d node_modules ]
tlucas 2018/09/04 07:19:37 Done.
26
27 prepare-dependencies:
28 stage: prepare
29 script: *dependencies
30 cache:
31 key: cache_$CI_COMMIT_SHA
32 paths:
33 - ./
34 policy: push
35
36 26
37 .test_template: &test_template 27 .test_template: &test_template
38 stage: test 28 stage: test
39 before_script: *dependencies 29 before_script: *dependencies
40 cache: 30 cache:
41 key: cache_$CI_COMMIT_SHA 31 key: cache_$CI_COMMIT_SHA
42 paths: 32 paths:
43 - ./ 33 - ./
44 policy: pull 34 policy: pull
45 35
46 36
37 prepare-dependencies:
38 stage: prepare
39 script: *dependencies
40 cache:
41 key: cache_$CI_COMMIT_SHA
42 paths:
43 - ./
44 policy: push
45
47 tests:gecko: 46 tests:gecko:
48 <<: *test_template 47 <<: *test_template
49 script: 48 script:
50 - npm test -- -g gecko 49 - npm run test-only -- -g gecko
51 50
52 tests:chrome: 51 tests:chrome:
53 <<: *test_template 52 <<: *test_template
54 script: 53 script:
55 - xvfb-run npm test -- -g chrome 54 - xvfb-run npm run test-only -- -g chrome
56 55
57 lint: 56 lint:
58 <<: *test_template 57 <<: *test_template
59 script: 58 script:
60 - npm run lint 59 - npm run lint
LEFTRIGHT
« no previous file | package.json » ('j') | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld