Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(205)

Issue 29868595: Issue 6909 - Make ensure_dependencies.py call "npm install" for non-repositories (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 3 months ago by Sebastian Noack
Modified:
1 year, 3 months ago
Reviewers:
tlucas
Visibility:
Public.

Description

Issue 6909 - Make ensure_dependencies.py call "npm install" for non-repositories

Patch Set 1 #

Total comments: 4

Patch Set 2 : Wrapped long lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -9 lines) Patch
M ensure_dependencies.py View 1 6 chunks +20 lines, -9 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
1 year, 3 months ago (2018-08-29 20:09:15 UTC) #1
tlucas
https://codereview.adblockplus.org/29868595/diff/29868596/ensure_dependencies.py File ensure_dependencies.py (right): https://codereview.adblockplus.org/29868595/diff/29868596/ensure_dependencies.py#newcode355 ensure_dependencies.py:355: def resolve_deps(repodir, repotype, level=0, self_update=True, overrideroots=None, skipdependencies=set()): Nit: please ...
1 year, 3 months ago (2018-08-29 21:19:15 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29868595/diff/29868596/ensure_dependencies.py File ensure_dependencies.py (right): https://codereview.adblockplus.org/29868595/diff/29868596/ensure_dependencies.py#newcode355 ensure_dependencies.py:355: def resolve_deps(repodir, repotype, level=0, self_update=True, overrideroots=None, skipdependencies=set()): On 2018/08/29 ...
1 year, 3 months ago (2018-08-30 00:42:33 UTC) #3
tlucas
1 year, 3 months ago (2018-08-30 00:49:13 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5