Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29868595: Issue 6909 - Make ensure_dependencies.py call "npm install" for non-repositories (Closed)

Created:
Aug. 29, 2018, 8:06 p.m. by Sebastian Noack
Modified:
Aug. 30, 2018, 1:02 a.m.
Reviewers:
tlucas
Visibility:
Public.

Description

Issue 6909 - Make ensure_dependencies.py call "npm install" for non-repositories

Patch Set 1 #

Total comments: 4

Patch Set 2 : Wrapped long lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -9 lines) Patch
M ensure_dependencies.py View 1 6 chunks +20 lines, -9 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
Aug. 29, 2018, 8:09 p.m. (2018-08-29 20:09:15 UTC) #1
tlucas
https://codereview.adblockplus.org/29868595/diff/29868596/ensure_dependencies.py File ensure_dependencies.py (right): https://codereview.adblockplus.org/29868595/diff/29868596/ensure_dependencies.py#newcode355 ensure_dependencies.py:355: def resolve_deps(repodir, repotype, level=0, self_update=True, overrideroots=None, skipdependencies=set()): Nit: please ...
Aug. 29, 2018, 9:19 p.m. (2018-08-29 21:19:15 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29868595/diff/29868596/ensure_dependencies.py File ensure_dependencies.py (right): https://codereview.adblockplus.org/29868595/diff/29868596/ensure_dependencies.py#newcode355 ensure_dependencies.py:355: def resolve_deps(repodir, repotype, level=0, self_update=True, overrideroots=None, skipdependencies=set()): On 2018/08/29 ...
Aug. 30, 2018, 12:42 a.m. (2018-08-30 00:42:33 UTC) #3
tlucas
Aug. 30, 2018, 12:49 a.m. (2018-08-30 00:49:13 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld