Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29869558: Issue 6741 - Use ES2015 classes in lib/synchronizer.js (Closed)

Created:
Aug. 30, 2018, 11:36 a.m. by Manish Jethani
Modified:
Sept. 4, 2018, 5:26 p.m.
Reviewers:
hub, Jon Sonesen
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Add @hideconstructor tag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -38 lines) Patch
M lib/synchronizer.js View 1 4 chunks +44 lines, -38 lines 0 comments Download

Messages

Total messages: 4
Manish Jethani
Aug. 30, 2018, 11:36 a.m. (2018-08-30 11:36:56 UTC) #1
Manish Jethani
Patch Set 1
Aug. 30, 2018, 11:38 a.m. (2018-08-30 11:38:29 UTC) #2
Manish Jethani
Patch Set 2: Add @hideconstructor tag We don't enforce the singleton pattern (there's no need ...
Aug. 30, 2018, 11:46 a.m. (2018-08-30 11:46:37 UTC) #3
hub
Sept. 4, 2018, 5:03 p.m. (2018-09-04 17:03:05 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld