lib/matcher.js - Issue 29869571: Issue 6741 - Use ES2015 classes in lib/matcher.js

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: lib/matcher.js

Issue 29869571: Issue 6741 - Use ES2015 classes in lib/matcher.js (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/

Left Patch Set: Address PS3 comments Created Sept. 5, 2018, 2:01 p.m.

Right Patch Set: Address PS4 Comments Created Sept. 7, 2018, 3:48 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 /*	1 /*

2 * This file is part of Adblock Plus <https://adblockplus.org/>,	2 * This file is part of Adblock Plus <https://adblockplus.org/>,

3 * Copyright (C) 2006-present eyeo GmbH	3 * Copyright (C) 2006-present eyeo GmbH

4 *	4 *

5 * Adblock Plus is free software: you can redistribute it and/or modify	5 * Adblock Plus is free software: you can redistribute it and/or modify

6 * it under the terms of the GNU General Public License version 3 as	6 * it under the terms of the GNU General Public License version 3 as

7 * published by the Free Software Foundation.	7 * published by the Free Software Foundation.

8 *	8 *

9 * Adblock Plus is distributed in the hope that it will be useful,	9 * Adblock Plus is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

(...skipping 400 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
411 return result;	411 return result;

412 }	412 }

413 }	413 }

414	414

415 exports.CombinedMatcher = CombinedMatcher;	415 exports.CombinedMatcher = CombinedMatcher;

416	416

417 /**	417 /**

418 * Shared {@link CombinedMatcher} instance that should usually be used.	418 * Shared {@link CombinedMatcher} instance that should usually be used.

419 * @type {CombinedMatcher}	419 * @type {CombinedMatcher}

420 */	420 */

421 let defaultMatcher = new CombinedMatcher();	421 let defaultMatcher = new CombinedMatcher();
Manish Jethani 2018/09/05 19:34:47 Nit: Hey, can we also add a blank line here? I did Nit: Hey, can we also add a blank line here? I didn't realize it was missing. Jon Sonesen 2018/09/07 03:06:44 Done. Show quoted text On 2018/09/05 19:34:47, Manish Jethani wrote: > Nit: Hey, can we also add a blank line here? I didn't realize it was missing. Done. Manish Jethani 2018/09/07 03:14:59 Looks like you forgot to upload the patch? Show quoted text On 2018/09/07 03:06:44, Jon Sonesen wrote: > On 2018/09/05 19:34:47, Manish Jethani wrote: > > Nit: Hey, can we also add a blank line here? I didn't realize it was missing. > > Done. Looks like you forgot to upload the patch? Manish Jethani 2018/09/07 03:18:02 Sorry, I just saw your email. Can you also upload Show quoted text On 2018/09/07 03:14:59, Manish Jethani wrote: > On 2018/09/07 03:06:44, Jon Sonesen wrote: > > On 2018/09/05 19:34:47, Manish Jethani wrote: > > > Nit: Hey, can we also add a blank line here? I didn't realize it was > missing. > > > > Done. > > Looks like you forgot to upload the patch? Sorry, I just saw your email. Can you also upload the latest patch here? It's just a formality. Nevertheless, LGTM.
	422

422 exports.defaultMatcher = defaultMatcher;	423 exports.defaultMatcher = defaultMatcher;

LEFT	RIGHT