Issue 29870565: Issue 6915 - Add developers to contributors page (Closed)
|
Created:
Aug. 31, 2018, 10:36 p.m. by Manish Jethani Modified:
Sept. 4, 2018, 1:15 p.m. Base URL:
https://hg.adblockplus.org/web.adblockplus.org/ Visibility:
Public. |
DescriptionI have added the names of developers that were missing from the list. The names are based on the commit logs of adblockpluschrome and its dependencies (buildtools, adblockpluscore, and adblockplusui) for the last one year. The order in which the names appear is roughly based on the order in which the developers joined the Adblock Plus project; when in doubt, I went by the developer's level of involvement in the project, based on my limited knowledge and the number of commits in the logs. I can't get this one hundred percent right of course, feel free to make suggestions.
I have left out the names of external contributors with one or two minor commits, since they would hardly qualify as "team" (but may be added later in a different section separately).
Patch Set 1 #
Total comments: 1
Patch Set 2 : Move new historical contributors to bottom #
Total comments: 12
Patch Set 3 : Address comments to Patch Set 2 #
Total comments: 4
Patch Set 4 : Address comments to Patch Set 3 #MessagesTotal messages: 10
Patch Set 1 This change is only about adding developers' names based on the commit logs. We should also think about adding other names, that's a separate topic. https://codereview.adblockplus.org/29870565/diff/29870566/pages/contributors.... File pages/contributors.html (left): https://codereview.adblockplus.org/29870565/diff/29870566/pages/contributors.... pages/contributors.html:123: <td>Sven Hartz</td> I have moved Sven and Andrey to historical contributors now.
Patch Set 2: Move new historical contributors to bottom
https://codereview.adblockplus.org/29870565/diff/29870568/pages/contributors.... File pages/contributors.html (right): https://codereview.adblockplus.org/29870565/diff/29870568/pages/contributors.... pages/contributors.html:112: <td>{{s4 Founder & Lead Developer}}</td> At least Wladimir is no longer the lead developer. We might as well move him to "Historical Contributors". If he is coming back we can update this page again. https://codereview.adblockplus.org/29870565/diff/29870568/pages/contributors.... pages/contributors.html:116: <td>{{s5 Lead Developer}}</td> For almost the last 2 years, all commits I see by Felix, are auto-generated commits by our release automation, plus he is de-facto not acting as lead developer of Adblock Plus anymore. https://codereview.adblockplus.org/29870565/diff/29870568/pages/contributors.... pages/contributors.html:123: <td>Eric Hughes</td> For reference, he was listed for his contributions on Adblock Plus for IE (which is a dead project by now). Not sure what to do with him. https://codereview.adblockplus.org/29870565/diff/29870568/pages/contributors.... pages/contributors.html:144: <td>{{s6 Developer}}</td> Nah, his last change to actual code was almost a year ago, and it doesn't seem that he still doing hands-on development himself. https://codereview.adblockplus.org/29870565/diff/29870568/pages/contributors.... pages/contributors.html:180: <td>{{s6 Developer}}</td> Nah, her only contribution appears to be a single trivial change to buildtools, where she removed redundant syntax (in a cross-repository cleanup attempt). Neither, do we have any other backend developers listed here.
Patch Set 3 https://codereview.adblockplus.org/29870565/diff/29870568/pages/contributors.... File pages/contributors.html (right): https://codereview.adblockplus.org/29870565/diff/29870568/pages/contributors.... pages/contributors.html:112: <td>{{s4 Founder & Lead Developer}}</td> On 2018/08/31 23:31:27, Sebastian Noack wrote: > At least Wladimir is no longer the lead developer. We might as well move him to > "Historical Contributors". If he is coming back we can update this page again. Done. https://codereview.adblockplus.org/29870565/diff/29870568/pages/contributors.... pages/contributors.html:116: <td>{{s5 Lead Developer}}</td> On 2018/08/31 23:31:27, Sebastian Noack wrote: > For almost the last 2 years, all commits I see by Felix, are auto-generated > commits by our release automation, plus he is de-facto not acting as lead > developer of Adblock Plus anymore. Fine, I have moved Felix to historical contributors. https://codereview.adblockplus.org/29870565/diff/29870568/pages/contributors.... pages/contributors.html:123: <td>Eric Hughes</td> On 2018/08/31 23:31:27, Sebastian Noack wrote: > For reference, he was listed for his contributions on Adblock Plus for IE (which > is a dead project by now). Not sure what to do with him. Moved to historical contributors. https://codereview.adblockplus.org/29870565/diff/29870568/pages/contributors.... pages/contributors.html:144: <td>{{s6 Developer}}</td> On 2018/08/31 23:31:27, Sebastian Noack wrote: > Nah, his last change to actual code was almost a year ago, and it doesn't seem > that he still doing hands-on development himself. If the criterion is strictly commits of some significance within the last one year [1], then I think we can leave this entry here for now. [1]: https://github.com/adblockplus/adblockpluschrome/commit/a5daadf8a5ca0172b7c01... https://codereview.adblockplus.org/29870565/diff/29870568/pages/contributors.... pages/contributors.html:180: <td>{{s6 Developer}}</td> On 2018/08/31 23:31:27, Sebastian Noack wrote: > Nah, her only contribution appears to be a single trivial change to buildtools, > where she removed redundant syntax (in a cross-repository cleanup attempt). > Neither, do we have any other backend developers listed here. Fair enough, done. https://codereview.adblockplus.org/29870565/diff/29870570/pages/contributors.... File pages/contributors.html (right): https://codereview.adblockplus.org/29870565/diff/29870570/pages/contributors.... pages/contributors.html:111: <td>Sebastian Noack</td> Since you are effectively now "Lead Developer" (even though we don't use that title), I'd like to to update the role here, if you don't mind.
https://codereview.adblockplus.org/29870565/diff/29870568/pages/contributors.... File pages/contributors.html (right): https://codereview.adblockplus.org/29870565/diff/29870568/pages/contributors.... pages/contributors.html:144: <td>{{s6 Developer}}</td> On 2018/09/01 00:29:04, Manish Jethani wrote: > On 2018/08/31 23:31:27, Sebastian Noack wrote: > > Nah, his last change to actual code was almost a year ago, and it doesn't seem > > that he still doing hands-on development himself. > > If the criterion is strictly commits of some significance within the last one > year [1], then I think we can leave this entry here for now. > > [1]: > https://github.com/adblockplus/adblockpluschrome/commit/a5daadf8a5ca0172b7c01... The point is with these criteria, we have to add Winsley now, just to remove him again in two months. That is why I suggest to not add him in the first place at the current point.
Patch Set 4 https://codereview.adblockplus.org/29870565/diff/29870568/pages/contributors.... File pages/contributors.html (right): https://codereview.adblockplus.org/29870565/diff/29870568/pages/contributors.... pages/contributors.html:144: <td>{{s6 Developer}}</td> On 2018/09/01 00:34:12, Sebastian Noack wrote: > On 2018/09/01 00:29:04, Manish Jethani wrote: > > On 2018/08/31 23:31:27, Sebastian Noack wrote: > > > Nah, his last change to actual code was almost a year ago, and it doesn't > seem > > > that he still doing hands-on development himself. > > > > If the criterion is strictly commits of some significance within the last one > > year [1], then I think we can leave this entry here for now. > > > > [1]: > > > https://github.com/adblockplus/adblockpluschrome/commit/a5daadf8a5ca0172b7c01... > > The point is with these criteria, we have to add Winsley now, just to remove him > again in two months. That is why I suggest to not add him in the first place at > the current point. Alright, done. https://codereview.adblockplus.org/29870565/diff/29870570/pages/contributors.... File pages/contributors.html (right): https://codereview.adblockplus.org/29870565/diff/29870570/pages/contributors.... pages/contributors.html:111: <td>Sebastian Noack</td> On 2018/09/01 00:29:04, Manish Jethani wrote: > Since you are effectively now "Lead Developer" (even though we don't use that > title), I'd like to to update the role here, if you don't mind. Alternatively we could add new roles like "Module Owner (Platform)", "Module Owner (UI)", and so on.
LGTM https://codereview.adblockplus.org/29870565/diff/29870570/pages/contributors.... File pages/contributors.html (right): https://codereview.adblockplus.org/29870565/diff/29870570/pages/contributors.... pages/contributors.html:111: <td>Sebastian Noack</td> On 2018/09/01 00:39:39, Manish Jethani wrote: > On 2018/09/01 00:29:04, Manish Jethani wrote: > > Since you are effectively now "Lead Developer" (even though we don't use that > > title), I'd like to to update the role here, if you don't mind. > > Alternatively we could add new roles like "Module Owner (Platform)", "Module > Owner (UI)", and so on. I don't have a strong opinion on the role titles at the moment.
On 2018/09/01 01:49:19, Sebastian Noack wrote: > LGTM Thanks! Julian, what do you think? https://codereview.adblockplus.org/29870565/diff/29870570/pages/contributors.... File pages/contributors.html (right): https://codereview.adblockplus.org/29870565/diff/29870570/pages/contributors.... pages/contributors.html:111: <td>Sebastian Noack</td> On 2018/09/01 01:49:18, Sebastian Noack wrote: > On 2018/09/01 00:39:39, Manish Jethani wrote: > > On 2018/09/01 00:29:04, Manish Jethani wrote: > > > Since you are effectively now "Lead Developer" (even though we don't use > that > > > title), I'd like to to update the role here, if you don't mind. > > > > Alternatively we could add new roles like "Module Owner (Platform)", "Module > > Owner (UI)", and so on. > > I don't have a strong opinion on the role titles at the moment. Acknowledged.
LGTM 
|
