Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Delta Between Two Patch Sets: pages/contributors.html

Issue 29870565: Issue 6915 - Add developers to contributors page (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org/
Left Patch Set: Move new historical contributors to bottom Created Aug. 31, 2018, 10:59 p.m.
Right Patch Set: Address comments to Patch Set 3 Created Sept. 1, 2018, 12:39 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 title=Adblock Plus - Contributor Credits 1 title=Adblock Plus - Contributor Credits
2 2
3 <head> 3 <head>
4 <style type="text/css"> 4 <style type="text/css">
5 #content 5 #content
6 { 6 {
7 width: 980px; 7 width: 980px;
8 } 8 }
9 9
10 #pageactions 10 #pageactions
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 <h3>{{s1 Team}}</h3> 101 <h3>{{s1 Team}}</h3>
102 <table class="contributors-table" rules="groups"> 102 <table class="contributors-table" rules="groups">
103 <thead> 103 <thead>
104 <tr> 104 <tr>
105 <td>{{s2 Name}}</td> 105 <td>{{s2 Name}}</td>
106 <td>{{s3 Role}}</td> 106 <td>{{s3 Role}}</td>
107 </tr> 107 </tr>
108 </thead> 108 </thead>
109 <tbody> 109 <tbody>
110 <tr class="first-item"> 110 <tr class="first-item">
111 <td>Wladimir Palant</td> 111 <td>Sebastian Noack</td>
112 <td>{{s4 Founder & Lead Developer}}</td>
Sebastian Noack 2018/08/31 23:31:27 At least Wladimir is no longer the lead developer.
Manish Jethani 2018/09/01 00:29:04 Done.
113 </tr>
114 <tr>
115 <td>Felix H. Dahlke</td>
116 <td>{{s5 Lead Developer}}</td> 112 <td>{{s5 Lead Developer}}</td>
Sebastian Noack 2018/08/31 23:31:27 For almost the last 2 years, all commits I see by
Manish Jethani 2018/09/01 00:29:04 Fine, I have moved Felix to historical contributor
117 </tr> 113 </tr>
118 <tr> 114 <tr>
119 <td>Thomas Greiner</td> 115 <td>Thomas Greiner</td>
120 <td>{{s6 Developer}}</td> 116 <td>{{s6 Developer}}</td>
121 </tr> 117 </tr>
122 <tr> 118 <tr>
123 <td>Eric Hughes</td>
Sebastian Noack 2018/08/31 23:31:27 For reference, he was listed for his contributions
Manish Jethani 2018/09/01 00:29:04 Moved to historical contributors.
124 <td>{{s6 Developer}}</td>
125 </tr>
126 <tr>
127 <td>Sebastian Noack</td>
128 <td>{{s6 Developer}}</td>
129 </tr>
130 <tr>
131 <td>Oleksandr Paraska</td> 119 <td>Oleksandr Paraska</td>
132 <td>{{s6 Developer}}</td> 120 <td>{{s6 Developer}}</td>
133 </tr> 121 </tr>
134 <tr> 122 <tr>
135 <td>Dave Barker</td> 123 <td>Dave Barker</td>
136 <td>{{s6 Developer}}</td> 124 <td>{{s6 Developer}}</td>
137 </tr> 125 </tr>
138 <tr> 126 <tr>
139 <td>Manvel Saroyan</td> 127 <td>Manvel Saroyan</td>
140 <td>{{s6 Developer}}</td> 128 <td>{{s6 Developer}}</td>
141 </tr> 129 </tr>
142 <tr> 130 <tr>
143 <td>Winsley von Spee</td>
144 <td>{{s6 Developer}}</td>
Sebastian Noack 2018/08/31 23:31:27 Nah, his last change to actual code was almost a y
Manish Jethani 2018/09/01 00:29:04 If the criterion is strictly commits of some signi
Sebastian Noack 2018/09/01 00:34:12 The point is with these criteria, we have to add W
Manish Jethani 2018/09/01 00:39:39 Alright, done.
145 </tr>
146 <tr>
147 <td>Sergei Zabolotskikh</td> 131 <td>Sergei Zabolotskikh</td>
148 <td>{{s6 Developer}}</td> 132 <td>{{s6 Developer}}</td>
149 </tr> 133 </tr>
150 <tr> 134 <tr>
151 <td>Jon Sonesen</td> 135 <td>Jon Sonesen</td>
152 <td>{{s6 Developer}}</td> 136 <td>{{s6 Developer}}</td>
153 </tr> 137 </tr>
154 <tr> 138 <tr>
155 <td>Hubert Figuière</td> 139 <td>Hubert Figuière</td>
156 <td>{{s6 Developer}}</td> 140 <td>{{s6 Developer}}</td>
157 </tr> 141 </tr>
158 <tr> 142 <tr>
159 <td>Manish Jethani</td> 143 <td>Manish Jethani</td>
160 <td>{{s6 Developer}}</td> 144 <td>{{s6 Developer}}</td>
161 </tr> 145 </tr>
162 <tr> 146 <tr>
163 <td>Tristan Lucas</td> 147 <td>Tristan Lucas</td>
164 <td>{{s6 Developer}}</td> 148 <td>{{s6 Developer}}</td>
165 </tr> 149 </tr>
166 <tr> 150 <tr>
167 <td>Andrea Giammarchi</td> 151 <td>Andrea Giammarchi</td>
168 <td>{{s6 Developer}}</td> 152 <td>{{s6 Developer}}</td>
169 </tr> 153 </tr>
170 <tr> 154 <tr>
171 <td>Georgiana Piscoi</td> 155 <td>Georgiana Piscoi</td>
172 <td>{{s6 Developer}}</td> 156 <td>{{s6 Developer}}</td>
173 </tr> 157 </tr>
174 <tr> 158 <tr>
175 <td>Tom Schuster</td> 159 <td>Tom Schuster</td>
176 <td>{{s6 Developer}}</td>
177 </tr>
178 <tr>
179 <td>Rose Howell</td>
180 <td>{{s6 Developer}}</td> 160 <td>{{s6 Developer}}</td>
Sebastian Noack 2018/08/31 23:31:27 Nah, her only contribution appears to be a single
Manish Jethani 2018/09/01 00:29:04 Fair enough, done.
181 </tr> 161 </tr>
182 </tbody> 162 </tbody>
183 </table> 163 </table>
184 </section> 164 </section>
185 165
186 <section id="other-contributors"> 166 <section id="other-contributors">
187 <h3>{{s14 Other Contributors}}</h3> 167 <h3>{{s14 Other Contributors}}</h3>
188 <table class="contributors-table" rules="groups"> 168 <table class="contributors-table" rules="groups">
189 <thead> 169 <thead>
190 <tr> 170 <tr>
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
269 <h3>{{s34 Historical Contributors}}</h3> 249 <h3>{{s34 Historical Contributors}}</h3>
270 <table class="contributors-table" rules="groups"> 250 <table class="contributors-table" rules="groups">
271 <thead> 251 <thead>
272 <tr> 252 <tr>
273 <td>{{s35 Name}}</td> 253 <td>{{s35 Name}}</td>
274 <td>{{s36 Role}}</td> 254 <td>{{s36 Role}}</td>
275 </tr> 255 </tr>
276 </thead> 256 </thead>
277 <tbody> 257 <tbody>
278 <tr class="first-item"> 258 <tr class="first-item">
259 <td>Wladimir Palant</td>
260 <td>{{s4 Founder & Lead Developer}}</td>
261 </tr>
262 <tr>
263 <td>Felix H. Dahlke</td>
264 <td>{{s5 Lead Developer}}</td>
265 </tr>
266 <tr>
279 <td>Rob Brown</td> 267 <td>Rob Brown</td>
280 <td>{{s37 Developer (Element Hiding Helper)}}</td> 268 <td>{{s37 Developer (Element Hiding Helper)}}</td>
281 </tr> 269 </tr>
282 <tr> 270 <tr>
283 <td>Fabrice Desré</td> 271 <td>Fabrice Desré</td>
284 <td>{{s38 Developer (Firefox for Mobile support)}}</td> 272 <td>{{s38 Developer (Firefox for Mobile support)}}</td>
285 </tr> 273 </tr>
286 <tr> 274 <tr>
287 <td>Hubird</td> 275 <td>Hubird</td>
288 <td>{{s39 Developer (blockable items improvement)}}</td> 276 <td>{{s39 Developer (blockable items improvement)}}</td>
(...skipping 18 matching lines...) Expand all
307 <td>Nickolay Ponomarev</td> 295 <td>Nickolay Ponomarev</td>
308 <td>{{s44 Developer (performance)}}</td> 296 <td>{{s44 Developer (performance)}}</td>
309 </tr> 297 </tr>
310 <tr> 298 <tr>
311 <td>Sebastian Schmidt (yath)</td> 299 <td>Sebastian Schmidt (yath)</td>
312 <td>{{s45 Developer (Adblock Plus for Android bug fix)}}</td> 300 <td>{{s45 Developer (Adblock Plus for Android bug fix)}}</td>
313 </tr> 301 </tr>
314 <tr> 302 <tr>
315 <td>Sven Hartz</td> 303 <td>Sven Hartz</td>
316 <td>{{s7 UX Designer & Developer}}</td> 304 <td>{{s7 UX Designer & Developer}}</td>
305 </tr>
306 <tr>
307 <td>Eric Hughes</td>
308 <td>{{s6 Developer}}</td>
317 </tr> 309 </tr>
318 <tr> 310 <tr>
319 <td>Andrey Novikov</td> 311 <td>Andrey Novikov</td>
320 <td>{{s6 Developer}}</td> 312 <td>{{s6 Developer}}</td>
321 </tr> 313 </tr>
322 </tbody> 314 </tbody>
323 </table> 315 </table>
324 </section> 316 </section>
LEFTRIGHT
« no previous file | no next file » | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld