Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Delta Between Two Patch Sets: pages/contributors.html

Issue 29870565: Issue 6915 - Add developers to contributors page (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org/
Left Patch Set: Address comments to Patch Set 2 Created Sept. 1, 2018, 12:18 a.m.
Right Patch Set: Address comments to Patch Set 3 Created Sept. 1, 2018, 12:39 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | no next file » | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 title=Adblock Plus - Contributor Credits 1 title=Adblock Plus - Contributor Credits
2 2
3 <head> 3 <head>
4 <style type="text/css"> 4 <style type="text/css">
5 #content 5 #content
6 { 6 {
7 width: 980px; 7 width: 980px;
8 } 8 }
9 9
10 #pageactions 10 #pageactions
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 <h3>{{s1 Team}}</h3> 101 <h3>{{s1 Team}}</h3>
102 <table class="contributors-table" rules="groups"> 102 <table class="contributors-table" rules="groups">
103 <thead> 103 <thead>
104 <tr> 104 <tr>
105 <td>{{s2 Name}}</td> 105 <td>{{s2 Name}}</td>
106 <td>{{s3 Role}}</td> 106 <td>{{s3 Role}}</td>
107 </tr> 107 </tr>
108 </thead> 108 </thead>
109 <tbody> 109 <tbody>
110 <tr class="first-item"> 110 <tr class="first-item">
111 <td>Sebastian Noack</td> 111 <td>Sebastian Noack</td>
Manish Jethani 2018/09/01 00:29:04 Since you are effectively now "Lead Developer" (ev
Manish Jethani 2018/09/01 00:39:39 Alternatively we could add new roles like "Module
Sebastian Noack 2018/09/01 01:49:18 I don't have a strong opinion on the role titles a
Manish Jethani 2018/09/01 02:31:40 Acknowledged.
112 <td>{{s5 Lead Developer}}</td> 112 <td>{{s5 Lead Developer}}</td>
113 </tr> 113 </tr>
114 <tr> 114 <tr>
115 <td>Thomas Greiner</td> 115 <td>Thomas Greiner</td>
116 <td>{{s6 Developer}}</td> 116 <td>{{s6 Developer}}</td>
117 </tr> 117 </tr>
118 <tr> 118 <tr>
119 <td>Oleksandr Paraska</td> 119 <td>Oleksandr Paraska</td>
120 <td>{{s6 Developer}}</td> 120 <td>{{s6 Developer}}</td>
121 </tr> 121 </tr>
122 <tr> 122 <tr>
123 <td>Dave Barker</td> 123 <td>Dave Barker</td>
124 <td>{{s6 Developer}}</td> 124 <td>{{s6 Developer}}</td>
125 </tr> 125 </tr>
126 <tr> 126 <tr>
127 <td>Manvel Saroyan</td> 127 <td>Manvel Saroyan</td>
128 <td>{{s6 Developer}}</td> 128 <td>{{s6 Developer}}</td>
129 </tr> 129 </tr>
130 <tr> 130 <tr>
131 <td>Winsley von Spee</td>
132 <td>{{s6 Developer}}</td>
133 </tr>
134 <tr>
135 <td>Sergei Zabolotskikh</td> 131 <td>Sergei Zabolotskikh</td>
136 <td>{{s6 Developer}}</td> 132 <td>{{s6 Developer}}</td>
137 </tr> 133 </tr>
138 <tr> 134 <tr>
139 <td>Jon Sonesen</td> 135 <td>Jon Sonesen</td>
140 <td>{{s6 Developer}}</td> 136 <td>{{s6 Developer}}</td>
141 </tr> 137 </tr>
142 <tr> 138 <tr>
143 <td>Hubert Figuière</td> 139 <td>Hubert Figuière</td>
144 <td>{{s6 Developer}}</td> 140 <td>{{s6 Developer}}</td>
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
311 <td>Eric Hughes</td> 307 <td>Eric Hughes</td>
312 <td>{{s6 Developer}}</td> 308 <td>{{s6 Developer}}</td>
313 </tr> 309 </tr>
314 <tr> 310 <tr>
315 <td>Andrey Novikov</td> 311 <td>Andrey Novikov</td>
316 <td>{{s6 Developer}}</td> 312 <td>{{s6 Developer}}</td>
317 </tr> 313 </tr>
318 </tbody> 314 </tbody>
319 </table> 315 </table>
320 </section> 316 </section>
LEFTRIGHT
« no previous file | no next file » | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld