Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29871628: Issue 6918 - Integrated the test pages with the WebDriver-based test runner (Closed)

Created:
Sept. 2, 2018, 1:41 a.m. by Sebastian Noack
Modified:
Sept. 4, 2018, 3:47 p.m.
Reviewers:
tlucas, hub
Visibility:
Public.

Description

Issue 6918 - Integrated the test pages with the WebDriver-based test runner

Patch Set 1 : #

Patch Set 2 : Don't skip previously broken test cases #

Total comments: 2

Patch Set 3 : Sort dependencies in package.json alphabetically #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -0 lines) Patch
M package.json View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M test/.eslintrc.json View 1 chunk +1 line, -0 lines 0 comments Download
A test/wrappers/pages.js View 1 1 chunk +157 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Sebastian Noack
Sept. 2, 2018, 1:42 a.m. (2018-09-02 01:42:47 UTC) #1
Sebastian Noack
The fixes to testpages.adblockplus.org landed. So I updated this patch to no longer ignored those ...
Sept. 3, 2018, 6:12 p.m. (2018-09-03 18:12:11 UTC) #2
hub
https://codereview.adblockplus.org/29871628/diff/29873566/package.json File package.json (right): https://codereview.adblockplus.org/29871628/diff/29873566/package.json#newcode23 package.json:23: "jimp": "^0.3.11" don't we usually keep the modules in ...
Sept. 4, 2018, 2:15 p.m. (2018-09-04 14:15:09 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29871628/diff/29873566/package.json File package.json (right): https://codereview.adblockplus.org/29871628/diff/29873566/package.json#newcode23 package.json:23: "jimp": "^0.3.11" On 2018/09/04 14:15:09, hub wrote: > don't ...
Sept. 4, 2018, 2:29 p.m. (2018-09-04 14:29:15 UTC) #4
tlucas
Sept. 4, 2018, 3:30 p.m. (2018-09-04 15:30:15 UTC) #5

Powered by Google App Engine
This is Rietveld