Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: pages/filters/popup.tmpl

Issue 29874607: Issue 6769 - Avoid hardcoding the URL (Closed)
Patch Set: Created Sept. 4, 2018, 4:23 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 title = $popup 1 title = $popup
2 template = testcase 2 template = testcase
3 3
4 {% set testcase_moreinfo = [ 4 {% set testcase_moreinfo = [
5 ("Filter Options", "https://adblockplus.org/filters#options"), 5 ("Filter Options", "https://adblockplus.org/filters#options"),
6 ] %} 6 ] %}
7 7
8 8
9 <script> 9 <script>
10 function do_popup() 10 function do_popup()
11 { 11 {
12 window.open("/en/popuptarget") 12 window.open("/en/popuptarget")
13 } 13 }
14 </script> 14 </script>
15 15
16 <section class="site-panel"> 16 <section class="site-panel">
17 <h2>$popup</h2> 17 <h2>$popup</h2>
18 <p>Check that usage of the $popup filter option is working as expected.</p> 18 <p>Check that usage of the $popup filter option is working as expected.</p>
19 <p>With the filter displayed below each test case added to ABP (or with the te stcase subscription installed and active), the popups triggered by the link/butt ons below should be blocked/closed.</p> 19 <p>With the filter displayed below each test case added to ABP (or with the te stcase subscription installed and active), the popups triggered by the link/butt ons below should be blocked/closed.</p>
20 </section> 20 </section>
21 21
22 <section class="site-panel"> 22 <section class="site-panel">
23 <h2>Link-based popup</h2> 23 <h2>Link-based popup</h2>
24 <div class="testcase-container"> 24 <div class="testcase-container">
25 <a href="/en/popuptarget" target="_blank">Link popup</a><br><br> 25 <a href="/en/popuptarget" target="_blank">Link popup</a><br><br>
26 </div> 26 </div>
27 <h3>Filters</h3> 27 <h3>Filters</h3>
28 <pre>||testpages.adblockplus.org/en/popuptarget^$popup</pre> 28 <pre>||{{ site_url|strip_proto }}/en/popuptarget^$popup</pre>
29 </section> 29 </section>
30 30
31 <section class="site-panel"> 31 <section class="site-panel">
32 <h2>Script-based popup</h2> 32 <h2>Script-based popup</h2>
33 <div class="testcase-container"> 33 <div class="testcase-container">
34 <button onclick="do_popup();">window.open() popup</button> 34 <button onclick="do_popup();">window.open() popup</button>
35 </div> 35 </div>
36 <h3>Filters</h3> 36 <h3>Filters</h3>
37 <pre>||testpages.adblockplus.org/en/popuptarget^$popup</pre> 37 <pre>||{{ site_url|strip_proto }}/en/popuptarget^$popup</pre>
38 </section> 38 </section>
OLDNEW
« no previous file with comments | « pages/filters/ping.tmpl ('k') | pages/filters/script.tmpl » ('j') | templates/plaintext.tmpl » ('J')

Powered by Google App Engine
This is Rietveld