Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: filters/strip_proto.py
Issue
29874607
:
Issue 6769 - Avoid hardcoding the URL (Closed)
Patch Set: Fixed some mistakes
Created Sept. 5, 2018, 4:59 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Fixed some mistakes
Patch Set 3: Rebased
Right:
Patch Set 1: None
Patch Set 2: Fixed some mistakes
Patch Set 3: Rebased
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
README.md
filters/domain.py
filters/strip_proto.py
includes/testcases.md
includes/testcases.tmpl
pages/abp-testcase-subscription.txt.tmpl
pages/exceptions/document.tmpl
pages/exceptions/element-hiding.tmpl
pages/exceptions/elemhide.tmpl
pages/exceptions/image.tmpl
pages/exceptions/popup.tmpl
pages/exceptions/script.tmpl
pages/exceptions/stylesheet.tmpl
pages/exceptions/subdocument.tmpl
pages/exceptions/xmlhttprequest.tmpl
pages/filters/blocking.tmpl
pages/filters/element-hiding.tmpl
pages/filters/element-hiding-emulation.tmpl
pages/filters/image.tmpl
pages/filters/object.tmpl
pages/filters/object-subrequest.tmpl
pages/filters/ping.tmpl
pages/filters/popup.tmpl
pages/filters/script.tmpl
pages/filters/stylesheet.tmpl
pages/filters/subdocument.tmpl
pages/filters/webrtc.tmpl
pages/filters/websocket.tmpl
pages/filters/xmlhttprequest.tmpl
pages/frames/testcase-img-05.tmpl
settings.ini
static/abp-testcase-subscription.txt
static/frames/testcase-img-05.html
templates/plaintext.tmpl
View unified diff
|
Download patch
« no previous file with comments
|
« filters/domain.py
('k') |
includes/testcases.md »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
def strip_proto(url):
2
return url.split("://", 1)[-1]
OLD
NEW
« no previous file with comments
|
« filters/domain.py
('k') |
includes/testcases.md »
('j') |
no next file with comments »
Edit Message
Issue 29874607: Issue 6769 - Avoid hardcoding the URL (Closed)
Created Sept. 4, 2018, 4:23 p.m. by kzar
Modified Sept. 25, 2018, 3:04 p.m.
Reviewers: rossg, Sebastian Noack
Base URL:
Comments: 1
+ 1 drafts
This is Rietveld