Delta Between Two Patch Sets: pages/exceptions/popup.tmpl
Issue 29874607:
Issue 6769 - Avoid hardcoding the URL (Closed)
Left Patch Set:
Created Sept. 4, 2018, 4:23 p.m.
Right Patch Set: Rebased
Created Sept. 24, 2018, 1:37 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« pages/exceptions/image.tmpl ('k')
|
pages/exceptions/script.tmpl » ('j')
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 title = $popup Exception | 1 title = $popup Exception |
| 2 template = testcase | 2 template = testcase |
| 3 | 3 |
| 4 {% set testcase_moreinfo = [ | 4 {% set testcase_moreinfo = [ |
| 5 ("Filter Options", "https://adblockplus.org/filters#options"), | 5 ("Filter Options", "https://adblockplus.org/filters#options"), |
| 6 ] %} | 6 ] %} |
| 7 | 7 |
| 8 <script> | 8 <script> |
| 9 function do_popup() | 9 function do_popup() |
| 10 { | 10 { |
| (...skipping 16 matching lines...) Expand all Loading... | |
| 27 <pre>||{{ site_url|strip_proto }}/en/exceptions/popup^$popup</pre> | 27 <pre>||{{ site_url|strip_proto }}/en/exceptions/popup^$popup</pre> |
| 28 <pre>@@||{{ site_url|strip_proto }}/en/exceptions/popup^$popup</pre> | 28 <pre>@@||{{ site_url|strip_proto }}/en/exceptions/popup^$popup</pre> |
| 29 </section> | 29 </section> |
| 30 | 30 |
| 31 <section class="site-panel"> | 31 <section class="site-panel"> |
| 32 <h2>Script-based popup</h2> | 32 <h2>Script-based popup</h2> |
| 33 <div class="testcase-container"> | 33 <div class="testcase-container"> |
| 34 <button onclick="do_popup();">window.open() popup</button> | 34 <button onclick="do_popup();">window.open() popup</button> |
| 35 </div> | 35 </div> |
| 36 <h3>Filters</h3> | 36 <h3>Filters</h3> |
| 37 ||{{ site_url|strip_proto }}/en/popuptarget^$popup | 37 <pre>||{{ site_url|strip_proto }}/en/popuptarget^$popup</pre> |
| 38 @@||{{ site_url|strip_proto }}/en/filters/popup-exception^$popup | 38 <pre>@@||{{ site_url|strip_proto }}/en/filters/popup-exception^$popup</pre> |
| 39 </section> | 39 </section> |
| LEFT | RIGHT |
« pages/exceptions/image.tmpl ('k')
|
pages/exceptions/script.tmpl » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
