Issue 6822 - Report browser test errors

test/runners/webdriver.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
 function executeScript(driver, name, script, scriptName, scriptArgs)
 {
   let realScript = `let f = ${script}
                     let callback = arguments[arguments.length - 1];
                     return Promise.resolve()
                       .then(() => f(...arguments))
                       .then(() => callback());`;
-  return driver.executeScript(`window.consoleLogs = [];
-                               let oldLog = console.log;
+  return driver.executeScript(`let oldLog = console.log;
                                console.log = msg => {

[Sebastian Noack, 2018/09/17 16:18:06]

What is about console.error(), console.warn(), etc.?

Also what is about unhandled exceptions (potentially in asynchronous callbacks)?

[hub, 2018/09/18 22:23:36]

Only console.log is used for reporting test results. Exception are also caught
by the framework.

-                                 window.consoleLogs.push(msg);
+                                 window.consoleLogs.log.push(msg);
                                  oldLog.call(this, msg);
                                };`)
     .then(() => driver.executeAsyncScript(realScript, scriptArgs))
     .then(() => driver.executeScript("return window.consoleLogs;"))
     .then(result =>
     {
       console.log(`\nBrowser tests in ${name}\n`);
-      result.forEach(item => console.log(item));
+      result.log.forEach(item => console.log(item));

[Sebastian Noack, 2018/09/17 16:18:06]

Nit: We generally prefer for..of loops of .forEach().

[hub, 2018/09/18 22:23:36]

Done.

+      if (result.failures != 0)
+        return Promise.reject("Test failure");
     })
-    .then(() => driver.quit())
-  ;
+    .finally(() => driver.quit());

[Sebastian Noack, 2018/09/17 16:18:06]

.finally() requires Node.js 10, but we still support Node.js 7.

[hub, 2018/09/18 22:23:36]

I have run this on Node 7 and 8 and it did work. I am not sure why though. Will
fix this it.

[Sebastian Noack, 2018/09/19 08:16:50]

I'm on Node.js 8.5.0 and Promise.resolve().finally gives me undefined. If this
code doesn't error out, then I guess it is not executed.

 }
 
 module.exports.executeScript = executeScript;