Issue 6822 - Report browser test errors

test/runners/chromium_remote_process.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 163 matching lines @@
       if (callResult.exceptionDetails)
         throwException(callResult.exceptionDetails, scriptName);
 
       let promiseResult = await Runtime.awaitPromise({
         promiseObjectId: callResult.result.objectId
       });
       if (promiseResult.exceptionDetails)
         throwException(promiseResult.exceptionDetails, scriptName);
 
       return Runtime.evaluate({
-        expression: "window.consoleLogs",
+        expression: "window._consoleLogs",
         returnByValue: true
       }).then(result =>
       {
         if (result.result.value.failures != 0)

[Sebastian Noack, 2018/09/17 16:18:06]

I'm not sure if I understand correctly, but wouldn't we want to log the failure
messages themselves rather than just seeing "Test failure" if any browser error
occurred?

[hub, 2018/09/18 22:23:36]

the messages ARE displayed aleready. Have always been. This is just for
propagating the error back up.

-          return Promise.reject("Test failure");
+          throw "Chromium (Remote Interface)";
       });
     }
     finally
     {
       client.close();
     }
   });
 }
 
 module.exports = function(script, scriptName, ...scriptArgs)
 {
   return ensureChromium(CHROMIUM_REVISION).then(chromiumPath =>
   {
     let child = startChromium(chromiumPath);
     return Promise.race([
       child.done,
       runScript(script, scriptName, scriptArgs)
     ]).then(result =>
     {
       child.kill();
       return result;
     }).catch(error =>
     {
       child.kill();
       throw error;
     });
   });
 };