Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: test/browser/_bootstrap.js

Issue 29874649: Issue 6822 - Report browser test errors (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Left Patch Set: Updated patch Created Sept. 18, 2018, 10:23 p.m.
Right Patch Set: throw instead of Promise.reject() Created Sept. 21, 2018, 3:39 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | test/runners/chromium_process.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 window._consoleLogs.failures += failures.length; 78 window._consoleLogs.failures += failures.length;
79 console.log( 79 console.log(
80 "\n" + 80 "\n" +
81 bold(error("FAILURES: ")) + 81 bold(error("FAILURES: ")) +
82 failures.length + "/" + assertions.length + " assertions failed" 82 failures.length + "/" + assertions.length + " assertions failed"
83 ); 83 );
84 } 84 }
85 else 85 else
86 { 86 {
87 console.log( 87 console.log(
88 "\n" + bold(ok("OK: ")) + 88 `\n ${bold(ok("OK: "))}${assertions.length} assertions (${assertions .duration}ms)`
89 assertions.length + " assertions (" + assertions.duration + "ms)"
Sebastian Noack 2018/09/19 08:16:51 Nit: Perhaps use a template string here.
hub 2018/09/20 00:19:56 Done.
90 ); 89 );
91 } 90 }
92 91
93 resolve(); 92 resolve();
94 } 93 }
95 }); 94 });
96 }); 95 });
97 } 96 }
98 97
99 module.exports = runTests; 98 module.exports = runTests;
LEFTRIGHT

Powered by Google App Engine
This is Rietveld