Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/runners/chromium_remote_process.js

Issue 29874649: Issue 6822 - Report browser test errors (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Minor reformat Created Sept. 14, 2018, 12:37 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/runners/chromium_remote_process.js
===================================================================
--- a/test/runners/chromium_remote_process.js
+++ b/test/runners/chromium_remote_process.js
@@ -174,16 +174,25 @@
if (callResult.exceptionDetails)
throwException(callResult.exceptionDetails, scriptName);
let promiseResult = await Runtime.awaitPromise({
promiseObjectId: callResult.result.objectId
});
if (promiseResult.exceptionDetails)
throwException(promiseResult.exceptionDetails, scriptName);
+
+ return Runtime.evaluate({
+ expression: "window.consoleLogs",
+ returnByValue: true
+ }).then(result =>
+ {
+ if (result.result.value.failures != 0)
Sebastian Noack 2018/09/17 16:18:06 I'm not sure if I understand correctly, but wouldn
hub 2018/09/18 22:23:36 the messages ARE displayed aleready. Have always b
+ return Promise.reject("Test failure");
+ });
}
finally
{
client.close();
}
});
}

Powered by Google App Engine
This is Rietveld